Added JUnit.xml support via --format junit #296
Conversation
| # frozen_string_literal: true | ||
|
|
||
| require "spec_helper" | ||
| require "pry" |
There was a problem hiding this comment.
This causes the test file to fail.
| <property name="erb_lint_version" value="0.3.1" /> | ||
| <property name="ruby_engine" value="ruby" /> | ||
| <property name="ruby_version" value="3.1.2" /> | ||
| <property name="ruby_patchlevel" value="20" /> | ||
| <property name="ruby_platform" value="arm64-darwin21" /> |
There was a problem hiding this comment.
These fail the test unless we're using the exact same ruby version as you did.
|
Here's an example of using REXML https://github.com/Shopify/ci-queue/blob/941e4fe39a5bfdfc3bb8c0ec2c5a0dfa71075c3e/ruby/lib/minitest/queue/junit_reporter.rb Testing your branch worked well in Buildkite as well, but one thing I noticed is that the line number is missing. According to that code, it seems like you can add a |
|
Sure thing, I'll look into it - thanks. |
|
@wscourge @etiennebarrie |
|
@mikoto2000 fine by me, thanks for doing this, and sorry for my negligence. Cheers. |
|
@wscourge Thank you. I will fork wscourge:main and create new pull request. |
|
OK, closing this one |
Addresses #295.
Shamelessly based on sj26/rspec_junit_formatter. I additionally validated the
spec/erb_lint/fixtures/junit.xmlwith xmlvalidation.com for a good measure.This is a minimal example, without timings and hostnames, but good enough to display this test summary on GitlabCI, and I assume on other CI interfaces as well.