Run non-autocorrectable linters in autocorrect mode; improve message #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaelfranca I added you as reviewer since you seem to be the one doing maintenance on this repository; feel free to reassign for review though! |
|
I think this PR may have introduced a regression. I'd appreciate your thoughts on #263 . Thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145
Run all configured/enabled linters even when in autocorrect mode, and improve the messaging somewhat when run in autocorrect mode.
I ran into this after configuring erb-lint with 12 total linters, of which only 9 are autocorrectable. The
dev stylecommand would run with autocorrect, but this may leave lint failures which were from non-autocorrectable linters. This would then cause CI to fail for the branch later, very annoyingly, when it's run without autocorrect mode.This PR causes a behavior change for
-a/--autocorrect, but it matches the behavior of Rubocop's autocorrect, and I think matches most users' expectations better.The message from a real project looks like so:
Additionally I have added tests for the autocorrect message output (which didn't exist before).