Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image behavior] fixed background jitter fix on mobile #2611

Merged
merged 1 commit into from
May 8, 2023
Merged

[Image behavior] fixed background jitter fix on mobile #2611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3127,6 +3127,7 @@ details-disclosure > details {
.animate--fixed > img:not(.zoom):not(.deferred-media__poster-button),
.animate--fixed > svg:not(.zoom):not(.deferred-media__poster-button) {
position: fixed;
height: 100vh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pair this with a width: auto to safeguard against stretching if future styles interfere here? I'm always overly cautious about images when it comes to that. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I agree, I was thinking of that but also not seeing an impact on the images I was testing. Probably safer to add it 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually messes with things 😅 and we already have declarations that set the width and max-width to 100% while the height is set to `100% too.

widthAuto.mp4

I could also set the height on the image wrapper instead 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well. We've got another width: 100% rule on the wrapper too, so I'm not sure that's much better. I think what we have here seems to work ok.

}

/* Animations */
Expand Down