Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate the multirow section #2526

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Animate the multirow section #2526

merged 2 commits into from
Apr 14, 2023

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 14, 2023

PR Summary:

Adds fade in on scroll animation to the Multirow section.

Why are these changes introduced?

Closes #2508.

What approach did you take?

Replicated animations from the original mockups in #2141

Visual impact on existing themes

Will animate Multirow sections on scroll, when "Reveal sections on scroll" is enabled.

multirow.mp4

Testing steps/scenarios

  • Ensure "Reveal sections on scroll" is checked within Theme Settings > Animations.
  • Add a Multirow section
  • Add/remove blocks and adjust settings. Ensure things continue to animate in smoothly.

Demo links

Checklist

Copy link
Contributor

@metamoni metamoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me! 👍

@kjellr kjellr merged commit dc62e32 into main Apr 14, 2023
@kjellr kjellr deleted the animate-multirow branch April 14, 2023 16:05
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Multirow] Add cascading fade in on scroll
3 participants