[Apps] Animate on scroll #2514
Merged
[Apps] Animate on scroll #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
requested review from
stufreen,
metamoni,
melissaperreault and
ludoboludo
ludoboludo
approved these changes
Apr 11, 2023
| @@ -1,4 +1,4 @@ | |||
| <div class="{% if section.settings.include_margins %}page-width{% endif %}"> | |||
| <div class="{% if section.settings.include_margins %}page-width{% endif %}{% if settings.animations_reveal_on_scroll %} scroll-trigger animate--slide-in{% endif %}"> | |||
There was a problem hiding this comment.
I guess some apps could be about adding image banners or images in general that could use a fade in instead of slide in animation. But I don't think we need to add a setting to the section at this point. We can see if it over comes up through our support channel as a request 👍
metamoni
approved these changes
Apr 12, 2023
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Why are these changes introduced?
Closes #2513
Visual impact on existing themes
Will animate the apps section when Reveal sections on scroll is enabled. Animation applies to the wrapper, so it will effect all blocks within that section at once (I think this is fine for now).
apps.mp4
Testing steps/scenarios
Demo links
Checklist