Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate rich text and email signup #2408

Merged
merged 15 commits into from
Apr 5, 2023
Merged

Conversation

metamoni
Copy link
Contributor

@metamoni metamoni commented Mar 15, 2023

PR Summary:

Adds fade in on scroll animation to the following sections:

  • Rich text
  • Email signup

Why are these changes introduced?

Fixes #2388

What approach did you take?

Replicated animations from the original prototype

Visual impact on existing themes

Will animate Rich text and Email signup sections on scroll, when Reveal sections on scroll is enabled

rich-text-email.mp4

Testing steps/scenarios

  • Enable Reveal sections on scroll under Animations in Theme settings
  • On the home page, add a Rich text section and verify that it fades in on scroll
  • Add an Email signup section and verify that it fades in on scroll

Demo links

Checklist

@metamoni metamoni self-assigned this Mar 15, 2023
@metamoni metamoni changed the base branch from animate-on-scroll to reveal-on-scroll-animations March 15, 2023 17:39
@metamoni metamoni changed the title Animate richt text email signup Animate rich text and email signup Mar 15, 2023
@kjellr
Copy link
Contributor

kjellr commented Mar 15, 2023

For these two sections, can we mimic the effect in #2409, where the background color does not animate, but the content slides in?

@melissaperreault
Copy link
Contributor

A note for refinement; perhaps we could reveal the first block first than the other one together? That would align well with how we do the cascade for cards in general.

@kjellr
Copy link
Contributor

kjellr commented Mar 16, 2023

A note for refinement; perhaps we could reveal the first block first than the other one together? That would align well with how we do the cascade for cards in general.

I think that's mostly just an effect of the demo above, and probably not a real-world scenario. Normally, you'd scroll into them and they'd appear one-by-one. If they're both at the top of the page, they might animate in all at once, but we've talked about trying to work around that. I'll open an issue to log some ideas around that.

Edit: #2417

@melissaperreault
Copy link
Contributor

A note for refinement; perhaps we could reveal the first block first than the other one together? That would align well with how we do the cascade for cards in general.

Sorry, my comment lacks clarity here. I was targeting the first block of the section, in this case, the title block. Than the other blocks; description and/or button could slide in.

@metamoni metamoni force-pushed the reveal-on-scroll-animations branch from 0e01a72 to 137ec32 Compare March 23, 2023 04:29
Base automatically changed from reveal-on-scroll-animations to main March 24, 2023 05:34
@metamoni metamoni force-pushed the animate-richt-text-email-signup branch from 596cef2 to b467dc0 Compare March 29, 2023 16:28
@metamoni metamoni changed the base branch from main to animate-featured-collection March 29, 2023 16:32
@metamoni
Copy link
Contributor Author

metamoni commented Mar 30, 2023

@kjellr is this what you're looking for with the background not animating?

email.signup.and.rich.text.mp4

@metamoni metamoni force-pushed the animate-richt-text-email-signup branch from 49bb6d9 to 835d40e Compare March 30, 2023 12:03
@kjellr
Copy link
Contributor

kjellr commented Mar 30, 2023

@metanomi Yes, that's right!

@melissaperreault was also suggesting that we could load the text in sequentially (so the header first, and then the body copy, etc.). If we can do that great, but it's also ok to push that to later.

@metamoni metamoni force-pushed the animate-featured-collection branch from 4235ec7 to 298c35f Compare March 30, 2023 13:44
@metamoni metamoni force-pushed the animate-richt-text-email-signup branch from 68b9090 to bee810b Compare March 30, 2023 13:56
@metamoni
Copy link
Contributor Author

@kjellr, @melissaperreault added the cascading effect to individual elements

kjellr
kjellr previously approved these changes Mar 30, 2023
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Looks great, thanks @metamoni!

Base automatically changed from animate-featured-collection to main March 30, 2023 15:23
@metamoni metamoni force-pushed the animate-richt-text-email-signup branch 2 times, most recently from 8df94bd to cb93e19 Compare March 31, 2023 11:59
@metamoni metamoni force-pushed the animate-richt-text-email-signup branch from cb93e19 to ebeb9d7 Compare April 3, 2023 12:40
Copy link
Contributor

@LucasLacerdaUX LucasLacerdaUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶👍

Copy link
Contributor

@melissaperreault melissaperreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Monica! 💪

Everything looks good! So fresh!
I did notice one thing to discuss how you feel; when we set the Email signup section padding lower than 76 pixels, the blocks appear on top of the next section. That's kind of the effect but I wonder if gives a buggy impression to the buyer?

@metamoni
Copy link
Contributor Author

metamoni commented Apr 4, 2023

when we set the Email signup section padding lower than 76 pixels, the blocks appear on top of the next section. That's kind of the effect but I wonder if gives a buggy impression to the buyer?

@kjellr, @melissaperreault how would you like the animation to work here?

@kjellr
Copy link
Contributor

kjellr commented Apr 4, 2023

I think that's ok for now. 👍 I imagine that's a common thing across different sections, and we can take a look at it later.

@metamoni metamoni merged commit 50328a6 into main Apr 5, 2023
@metamoni metamoni deleted the animate-richt-text-email-signup branch April 5, 2023 09:16
pangloss added a commit to pangloss/dawn that referenced this pull request Apr 5, 2023
* shopify/main:
  [Video] Add fade in on scroll animation (Shopify#2495)
  Animate rich text and email signup (Shopify#2408)
  [Gift card] Add help doc link and change label for translation (Shopify#2471)
  Add prettier config to support format-on-save (Shopify#2323)
  Announcements slideshow (Shopify#2394)
  fix: Update Follow on Shop Option Text (Shopify#2463)
  Enable "per-PR" async PR mode (Shopify#2488)
  Animate multicolumn (Shopify#2409)
  Fix improper image sizes in the collage section (Shopify#2478)
  Replaced depreciated liquid property/value (Shopify#2480)
pangloss added a commit to pangloss/dawn that referenced this pull request Apr 12, 2023
* next:
  [Video] Add fade in on scroll animation (Shopify#2495)
  Animate rich text and email signup (Shopify#2408)
  [Gift card] Add help doc link and change label for translation (Shopify#2471)
  Add prettier config to support format-on-save (Shopify#2323)
  Announcements slideshow (Shopify#2394)
  fix: Update Follow on Shop Option Text (Shopify#2463)
  Enable "per-PR" async PR mode (Shopify#2488)
  Animate multicolumn (Shopify#2409)
  Fix improper image sizes in the collage section (Shopify#2478)
  Replaced depreciated liquid property/value (Shopify#2480)
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
  Update from Shopify for theme dawn/next
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
add fade in on scroll animation to Rich text and Email signup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rich text] and [Email signup]: Add cascading fade in on scroll animation
5 participants