-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate rich text and email signup #2408
Conversation
For these two sections, can we mimic the effect in #2409, where the background color does not animate, but the content slides in? |
A note for refinement; perhaps we could reveal the first block first than the other one together? That would align well with how we do the cascade for cards in general. |
I think that's mostly just an effect of the demo above, and probably not a real-world scenario. Normally, you'd scroll into them and they'd appear one-by-one. If they're both at the top of the page, they might animate in all at once, but we've talked about trying to work around that. I'll open an issue to log some ideas around that. Edit: #2417 |
Sorry, my comment lacks clarity here. I was targeting the first block of the section, in this case, the title block. Than the other blocks; description and/or button could slide in. |
0e01a72
to
137ec32
Compare
596cef2
to
b467dc0
Compare
@kjellr is this what you're looking for with the background not animating? email.signup.and.rich.text.mp4 |
49bb6d9
to
835d40e
Compare
@metanomi Yes, that's right! @melissaperreault was also suggesting that we could load the text in sequentially (so the header first, and then the body copy, etc.). If we can do that great, but it's also ok to push that to later. |
4235ec7
to
298c35f
Compare
68b9090
to
bee810b
Compare
@kjellr, @melissaperreault added the cascading effect to individual elements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looks great, thanks @metamoni!
8df94bd
to
cb93e19
Compare
* add animation to Image banner and Image with text
cb93e19
to
ebeb9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐶👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Monica! 💪
Everything looks good! So fresh!
I did notice one thing to discuss how you feel; when we set the Email signup section padding lower than 76 pixels, the blocks appear on top of the next section. That's kind of the effect but I wonder if gives a buggy impression to the buyer?
@kjellr, @melissaperreault how would you like the animation to work here? |
I think that's ok for now. 👍 I imagine that's a common thing across different sections, and we can take a look at it later. |
* shopify/main: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480)
* next: [Video] Add fade in on scroll animation (Shopify#2495) Animate rich text and email signup (Shopify#2408) [Gift card] Add help doc link and change label for translation (Shopify#2471) Add prettier config to support format-on-save (Shopify#2323) Announcements slideshow (Shopify#2394) fix: Update Follow on Shop Option Text (Shopify#2463) Enable "per-PR" async PR mode (Shopify#2488) Animate multicolumn (Shopify#2409) Fix improper image sizes in the collage section (Shopify#2478) Replaced depreciated liquid property/value (Shopify#2480) Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next Update from Shopify for theme dawn/next
add fade in on scroll animation to Rich text and Email signup
PR Summary:
Adds fade in on scroll animation to the following sections:
Why are these changes introduced?
Fixes #2388
What approach did you take?
Replicated animations from the original prototype
Visual impact on existing themes
Will animate Rich text and Email signup sections on scroll, when
Reveal sections on scroll
is enabledrich-text-email.mp4
Testing steps/scenarios
Reveal sections on scroll
underAnimations
in Theme settingsDemo links
Checklist