Remove "hover" option for image zoom #2283
Conversation
stufreen
requested review from
LucasLacerdaUX,
ludoboludo,
kmeleta and
sofiamatulis
| @@ -1424,18 +1424,13 @@ | |||
| "value": "lightbox", | |||
| "label": "t:sections.main-product.settings.image_zoom.options__1.label" | |||
There was a problem hiding this comment.
Should we be removing the translations too? 🤔
There was a problem hiding this comment.
Ideally, we keep the translations. Similar to the dead code, it just makes our lives easier without causing any negatives.
The translation platform should have some memory of previous translations so that won't cause issues with time whenever we revisit it on the next release, BUT translation conflicts are a pain to deal with so let's just keep it there. There's not much negative in having some extra unused strings.
| @@ -1424,18 +1424,13 @@ | |||
| "value": "lightbox", | |||
| "label": "t:sections.main-product.settings.image_zoom.options__1.label" | |||
| }, | |||
There was a problem hiding this comment.
I guess this can be commented out or removed for now too 🤔 https://screenshot.click/03-58-akjn2-e2l2x.png
There was a problem hiding this comment.
I would say to keep it. It's okay if we're revisiting it soon.
As long as that condition will never be true, it's okay to leave some dead code in to save us some time when we fix this feature.
Remove "hover" option for image zoom (Shopify#2283)
PR Summary:
Removes the "hover" option from the Image Zoom settings.
Why are these changes introduced?
We discovered a bug where transparent PNG files would show the thumbnail image below the hovered image. We will remove the option for now and fix for a future release.
What approach did you take?
Comments out the option and the label (which is only relevant for hover).
Decision log
Visual impact on existing themes
NA
Testing steps/scenarios
Demo links
Checklist