Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder color setting in Header #2231

Merged
merged 10 commits into from
Feb 15, 2023
Merged

Conversation

melissaperreault
Copy link
Contributor

@melissaperreault melissaperreault commented Jan 18, 2023

PR Summary:

Reorders the "Color scheme" setting lower in the settings list to improve settings hierarchy.

Why are these changes introduced?

Fixes #2232

  • We should list settings that require action/input from the merchant first.

What approach did you take?

Reordered the settings

Other considerations

We might improve those patterns hierarchy later but wanted to improve this order sooner for the Header section.

Decision log

# Decision Alternatives Rationale Downsides
1 Do not add an additional Header for grouping non Logo settings together (WIP) Adding a new header to improve the grouping. The solo Logo header gives the impression that all the settings below it are Logo related. Adding the extra header or removing the “Logo” header might achieve the same effect without introducing more labels. We could reverse the “edit your logo in theme settings” link to below the desktop logo position setting Might be hard to find or scan the right setting at first look
2 Remove the Logo header completely Keep the Logo header Keeping the info and placing it below the solo Logo setting has the same result. Also avoid adding more headers for now and reduce clutters. Since logo was moved to Theme settings, perhaps having a header to introduce the logo setting might be more discoverable

Visual impact on existing themes

Testing steps/scenarios

  • Click on the Header section
  • Explore the settings' order, the Color scheme setting should be below the Show separator line setting.

Demo links

Checklist

@melissaperreault melissaperreault marked this pull request as ready for review January 18, 2023 21:14
Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one feedback. The rest is looking good 👍.

Copy link
Contributor

@kmeleta kmeleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I think we can further clean up. Otherwise looks good and I'm aligned with the approach to remove the headers.

sections/header.liquid Show resolved Hide resolved
Copy link
Contributor

@eugenekasimov eugenekasimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🚀

@melissaperreault melissaperreault merged commit a61ce12 into main Feb 15, 2023
@melissaperreault melissaperreault deleted the header-color-setting-order branch February 15, 2023 22:06
chris-kreidl added a commit to uniorusa/unior-usa-b2b that referenced this pull request Feb 16, 2023
Reorder color setting in Header (Shopify#2231)
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* reorder color setting

* add extra header

* move below separator line

* testing alternative

* remove header content

* changing content to info

* testing locale change

* changes

* revert

* remove unused content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder the Color scheme setting from the Header section
3 participants