-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slideshow + Image Banner when no container are limited to white text on image #1391
Comments
A few discussion points to consider
|
This is a tricky one because it depends so much on the overall darkness of the image. Also, in schemes with dark text colors: if we don't make the text white by default, the text will be unreadable whenever the image overlay opacity past a certain percentage. The overlay color is hardcoded to black. As noted above, I think the simplest UX solution might be to give folks a checkbox that allows them to choose between white or the text color set in the scheme. We might also consider changing Dawn's default homepage layout to use the content container on desktop. That won't fix the problem, but it will at least provide users with something that works less awkwardly with Color Schemes by default. |
^ Update to my note above: it's definitely hard to arrive on a default that works for everyone, but we're already pretty far from that today. A great example is that if someone adds an Image Banner or Slideshow today, and then immediately turns off the content container, they're met with this: Our own forced-white text works against us there and breaks the experience. The only way for the merchant to get around it is by uploading a dark image, or by increasing in the overlay opacity. In light of all that, #2663 seems like a generally reasonable solution to me: It retains the white text on Dawn's homepage by default, and also allows merchants to modify colors like they would anywhere else in the theme. It's not perfect, but it still allows for more good outcomes than our current solution. |
We found some confusing bits to #2663, so here's a more modest proposal for consideration as well. This one aims to make it more clear that the color scheme is only used when the container is displayed, by reordering settings and placing the info messaging before the color scheme setting instead of after it. The changes are:
cc @katycobb: do you have any thoughts on that rewrite of the "Visible when container displayed" copy there? We want to be super clear that it's in reference to the color palette control. |
Because of the UI and space between the settings e.g. We could also temporary change the label of the |
Hi! Agreed with @melissaperreault and @kimberlyoleiro's suggestion to change I think the help text clarifying when the color scheme applies might be better placed under the color scheme itself. We could add it before the existing help text, so it'd go something like:
Looking at the root issue here though - it seems like it's a problem of unpredictable text color specifically. While it's correct to say that the color scheme is only applied when the container is shown, it's still a layer of abstraction away from the problem merchants are experiencing, which is text color specifically. Thoughts on getting more granular with something like this? I know in theory merchants should understand that color schemes affect text colors, but in this case it might help to extra-clarify if we believe it's a confusing experience. Edit: another idea -
|
Unfortunately not possible because the |
The text is great. Let's try it! Can always make changes again in the future. |
Let's ship this! 🚀 |
I don't mind moving the overlay opacity control. It makes sense to keep it consistent. Regarding the idea here though, we didn't consider just adding a header there. I think this is probably a simpler solution, and avoids us having to add yet another line of explanatory text to the theme: It shows that the color scheme is clearly tied to the container. It does not clarify about the white text behavior, but I think that's ok in this case. |
That, but also the white text is meant to play off the black overlay if I'm not mistaken. So it would make sense to keep that near any note or setting related to the white text. Though if we remove that info text, it still doesn't hurt jusr probably not as impactful.
We should add a heading for sure, but I personally wouldn't mind both if this is a real pain point for people. There's not that much helper text in these particular sections right now. |
My gut says that 2 things are confusing to merchants: 1. the container checkbox setting is just getting lost in the hierarchy 2. no one knows what a container is. To Ken's point, I think using a mix of header and helper text can solve both problems. What do y'all think of this? @kmeleta @kjellr @katycobb @melissaperreault Header: |
Most aligned with @kjellr's suggestion here:
|
Describe the current behavior
When opting to remove the container on slideshow or image banner, text is always white. This is not ideal when the image a merchant wishes to use is light.
We should let merchants pick the text color, or have them pick between white or their globally set text color.
Update: May 17th, 2023
This issue was flagged by leadership twice. We will prioritize a fix
The text was updated successfully, but these errors were encountered: