-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethrow functions esbuild errors #5231
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success2004 tests passing in 905 suites. Report generated by 🧪jest coverage report action from 8938052 |
We detected some changes at packages/*/src and there are no updates in the .changeset. |
23d656e
to
a1b5698
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.74.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.73.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/notifications-system.d.ts@@ -166,11 +166,25 @@ export type Notifications = zod.infer<typeof NotificationsSchema>;
*/
export declare function showNotificationsIfNeeded(currentSurfaces?: string[], environment?: NodeJS.ProcessEnv): Promise<void>;
/**
- * Get notifications list from cache (refreshed every hour) or fetch it if not present.
+ * Get notifications list from cache, that is updated in the background from bin/fetch-notifications.json.
*
* @returns A Notifications object.
*/
export declare function getNotifications(): Promise<Notifications>;
+/**
+ * Fetch notifications from the CDN and chache them.
+ *
+ * @returns A string with the notifications.
+ */
+export declare function fetchNotifications(): Promise<Notifications>;
+/**
+ * Fetch notifications in background as a detached process.
+ *
+ * @param currentCommand - The current Shopify command being run.
+ * @param argv - The arguments passed to the current process.
+ * @param environment - Process environment variables.
+ */
+export declare function fetchNotificationsInBackground(currentCommand: string, argv?: string[], environment?: NodeJS.ProcessEnv): void;
/**
* Filters notifications based on the version of the CLI.
*
packages/cli-kit/dist/public/node/system.d.ts@@ -12,6 +12,7 @@ export interface ExecOptions {
input?: string;
signal?: AbortSignal;
externalErrorHandler?: (error: unknown) => Promise<void>;
+ background?: boolean;
}
/**
* Opens a URL in the user's default browser.
|
WHY are these changes introduced?
We want ESBuild errors from functions to appear in the dev logs.
WHAT is this pull request doing?
If a javascript function throws an ESBuild error, re-throw as it is and the dev-session will automatically parse and format it.
How to test your changes?
Measuring impact
Checklist