Fix speedscope error on shopify theme profile

[karreiro]

Fix the speedscope error on shopify theme profile

Before:

After:

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.14% (+0.01% 🔼)	8867/11800
🟡	Branches	70.33% (+0.02% 🔼)	4311/6130
🟡	Functions	75.06%	2318/3088
🟡	Lines	75.71% (+0.01% 🔼)	8383/11072

Test suite run success

2000 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from 9b8226e

[macournoyer]

THANK YOU! 🙇

[jamesmengo]

I wanted to dig into why we needed to include speedscope again in the cli package. Leaving this note for future readers (I'm not too familiar with bundling so I may be off base - feel free to add corrections)

1. In @shopify/theme:

"dependencies": {
  "speedscope": "1.21.0"  // Needed because theme uses speedscope directly
}

• Theme package actually uses speedscope for profiling
• It's marked as private: true, so its dependencies aren't visible to other packages

2. In @shopify/cli:

"dependencies": {
  "speedscope": "1.21.0"  // Needed for Node 18 compatibility
}

• CLI is the public package that users install
• Needs speedscope for Node 18's require.resolve to work
• Can't see theme's dependencies because it's private

The root cause is:

1. We need to access speedscope's HTML file at runtime - here
2. We support both Node 18 (CommonJS) and Node 20+ (ESM)
3. CommonJS's require.resolve can't see dependencies of private packages
4. Therefore, the public package needs its own copy of speedscope for Node 18 compatibility

This wouldn't be necessary if we either:

1. Only supported Node 20+ (could use import.meta.resolve)
2. Made @shopify/theme public (dependencies would be visible)
3. Didn't need to access speedscope's files directly

[macournoyer]

Didn't need to access speedscope's files directly

That would make the profile feature not possible to implement, no?