Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for default checkout event processor #10

Merged
merged 2 commits into from
Nov 23, 2023
Merged

add tests for default checkout event processor #10

merged 2 commits into from
Nov 23, 2023

Conversation

kiftio
Copy link
Contributor

@kiftio kiftio commented Nov 23, 2023

What are you trying to accomplish?

Updates DefaultCheckoutEventProcessor

  1. Replaces the println() call with a Log.w() call
  2. Adds tests
  3. Adds a LogWrapper to allow asserting on log messages

Before you deploy

@kiftio kiftio requested a review from a team as a code owner November 23, 2023 11:37
Bruno125
Bruno125 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Bruno125 Bruno125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚀

leandrooriente
leandrooriente approved these changes Nov 23, 2023
View reviewed changes
Copy link

@leandrooriente leandrooriente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiftio kiftio merged commit c096f73 into main Nov 23, 2023
4 checks passed
@kiftio kiftio deleted the dk/remove-println branch November 23, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bruno125 Bruno125 Bruno125 approved these changes

@markmur markmur markmur approved these changes

@leandrooriente leandrooriente leandrooriente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiftio @leandrooriente @markmur @Bruno125