fix raw_ssl_request method for ruby 3.2.0 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztofbialek
force-pushed
the
ruby-3-2-1-posts-data-fix
branch
from
ada08a0 to
aafbbfe
Compare
With ruby 3.2.1 upgrade depracated method for calling =~ on Object was removed https://bugs.ruby-lang.org/issues/15231 This causes `logger.warn "#{self.class} posting to plaintext endpoint, which is insecure" if logger unless endpoint =~ /^https:/` to throw an error. Casting endpoint to string resolves this problem as all objects for handling uri should respond to `to_s` method
krzysztofbialek
force-pushed
the
ruby-3-2-1-posts-data-fix
branch
from
aafbbfe to
75380e1
Compare
musialik-shopify
approved these changes
Mar 22, 2023
Merged
krzysztofbialek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ruby 3.2.0 upgrade depracated method for calling
=~onObjectwas removed as described here: https://bugs.ruby-lang.org/issues/15231This causes:
logger.warn "#{self.class} posting to plaintext endpoint, which is insecure" if logger unless endpoint =~ /^https:/to throw an error.Casting
endpointtoStringexplicitly before the match solves the issue.