Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update setup.py #69

wants to merge 1 commit into from

Conversation

mkmrabby
Copy link

Support for the python 3.10 in order to run on Databricks runtime 13.3.

Describe the big picture - why are we doing this?

Any additional details to clarify code in the PR?

How is this tested?

Pull Request Checklist

  • Pull request includes a description of why we are doing this
  • CHANGELOG has been updated
  • Version in _version.py has been updated
  • All tests in the tests folder pass with a local build
  • README has been updated (if applicable)
  • Documentation in docs has been updated (if applicable)
  • requirements.txt and requirements-dev.txt have been recompiled (if applicable)
  • Docker image can be built using docker build -t collie .

Screenshots or GIFs?

Support for the python 3.10 in order to run on Databricks runtime 13.3.
@mkmrabby mkmrabby requested a review from a team February 21, 2024 16:29
@mkmrabby mkmrabby closed this Feb 21, 2024
@mkmrabby mkmrabby reopened this Feb 21, 2024
@mkmrabby
Copy link
Author

Need to update to python 3.10 for Databricks runtime 13.3

@@ -74,5 +74,6 @@
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also worth adding Python 3.11 support here too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes.

Copy link

@dnicholas-sr dnicholas-sr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to consider adding 3.11 as per Nathan's suggestion.

Copy link
Author

@mkmrabby mkmrabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes in Databricks run time 1.13.

@@ -74,5 +74,6 @@
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes.

@nathancooperjones
Copy link
Collaborator

nathancooperjones commented Feb 21, 2024

@mkmrabby @dnicholas-sr gotcha! Relatedly, I have a couple Collie changes I would love to be able to make - who on the SR team could I tag to review those PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants