-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #69
base: main
Are you sure you want to change the base?
Update setup.py #69
Conversation
Support for the python 3.10 in order to run on Databricks runtime 13.3.
Need to update to python 3.10 for Databricks runtime 13.3 |
@@ -74,5 +74,6 @@ | |||
'Programming Language :: Python :: 3.7', | |||
'Programming Language :: Python :: 3.8', | |||
'Programming Language :: Python :: 3.9', | |||
'Programming Language :: Python :: 3.10', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also worth adding Python 3.11 support here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You might want to consider adding 3.11 as per Nathan's suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes in Databricks run time 1.13.
@@ -74,5 +74,6 @@ | |||
'Programming Language :: Python :: 3.7', | |||
'Programming Language :: Python :: 3.8', | |||
'Programming Language :: Python :: 3.9', | |||
'Programming Language :: Python :: 3.10', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add Python 3.11 besides Python 3.10. But currently, I need Python 3.10 for my testing purposes.
@mkmrabby @dnicholas-sr gotcha! Relatedly, I have a couple Collie changes I would love to be able to make - who on the SR team could I tag to review those PRs? |
Support for the python 3.10 in order to run on Databricks runtime 13.3.
Describe the big picture - why are we doing this?
Any additional details to clarify code in the PR?
How is this tested?
Pull Request Checklist
CHANGELOG
has been updated_version.py
has been updatedtests
folder pass with a local buildREADME
has been updated (if applicable)docs
has been updated (if applicable)requirements.txt
andrequirements-dev.txt
have been recompiled (if applicable)docker build -t collie .
Screenshots or GIFs?