declare the stream::Priority as enum class, test=develop

Shixiaowei02 · Apr 22, 2020 · 2b0e12b · 2b0e12b
1 parent 8cf6932
commit 2b0e12b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/paddle/fluid/platform/device_context.cc b/paddle/fluid/platform/device_context.cc
@@ -223,7 +223,7 @@ void CUDAContext::InitEigenContext() {
 }
 
 CUDAContext::CUDAContext(const CUDAPlace& place,
-                         const enum stream::Priority& priority) {
+                         const stream::Priority& priority) {
   place_ = place;
   CUDADeviceGuard guard(place_.device);
   stream_.reset(new stream::CUDAStream(place, priority));

diff --git a/paddle/fluid/platform/device_context.h b/paddle/fluid/platform/device_context.h
@@ -85,7 +85,7 @@ class CUDAContext {
   CUDAContext() = default;
   explicit CUDAContext(
       const CUDAPlace& place,
-      const enum stream::Priority& priority = stream::Priority::kNormal);
+      const stream::Priority& priority = stream::Priority::kNormal);
 
   ~CUDAContext();
 
@@ -281,11 +281,11 @@ class CUDADeviceContext : public DeviceContext {
     return context()->Stream()->WaitCallback();
   }
 
-  void ResetDefaultContext(const enum stream::Priority& priority) {
+  void ResetDefaultContext(const stream::Priority& priority) {
     default_ctx_.reset(new CUDAContext(place_, priority));
   }
 
-  void ResetThreadContext(const enum stream::Priority& priority) {
+  void ResetThreadContext(const stream::Priority& priority) {
     std::lock_guard<std::mutex> guard(ctx_mtx_);
     thread_ctx_[this].reset(new CUDAContext(place_, priority));
   }

diff --git a/paddle/fluid/platform/stream/cuda_stream.cc b/paddle/fluid/platform/stream/cuda_stream.cc
@@ -22,7 +22,7 @@ namespace stream {
 
 constexpr unsigned int kDefaultFlag = cudaStreamDefault;
 
-bool CUDAStream::Init(const Place& place, const enum Priority& priority) {
+bool CUDAStream::Init(const Place& place, const Priority& priority) {
   PADDLE_ENFORCE_EQ(is_gpu_place(place), true,
                     platform::errors::InvalidArgument(
                         "Cuda stream must be created using cuda place."));

diff --git a/paddle/fluid/platform/stream/cuda_stream.h b/paddle/fluid/platform/stream/cuda_stream.h
@@ -36,14 +36,13 @@ enum class Priority : uint8_t {
 class CUDAStream final {
  public:
   CUDAStream() = default;
-  CUDAStream(const Place& place,
-             const enum Priority& priority = Priority::kNormal) {
+  explicit CUDAStream(const Place& place,
+                      const Priority& priority = Priority::kNormal) {
     Init(place, priority);
   }
   virtual ~CUDAStream() { Destroy(); }
 
-  bool Init(const Place& place,
-            const enum Priority& priority = Priority::kNormal);
+  bool Init(const Place& place, const Priority& priority = Priority::kNormal);
 
   template <typename Callback>
   void AddCallback(Callback&& callback) const {