Add login/profile widget to nav bar. #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the login page to be discoverable, since previously, you had to manually type in the address of the login page into the address bar. This is gated as a new whitelabel property named `loginEnabled`, which is only being enabled on the SFSG site and the legacy default askdarcel site.
richardxia
requested review from
jjfreund,
schroerbrian,
lgarofalo and
katerina-kossler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1347.
This allows the login page to be discoverable, since previously, you had to manually type in the address of the login page into the address bar. This is gated as a new whitelabel property named
loginEnabled, which is only being enabled on the SFSG site and the legacy default askdarcel site.Here are a few screenshots:
Log In link (signed out)
Profile menu icon (signed in)
Popover profile menu open (signed in)