Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added miscellaneous examples using dependent js from application.js #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added miscellaneous examples using dependent js from application.js #18

wants to merge 1 commit into from

Conversation

Prakriti-nith
Copy link
Collaborator

mis0
mis1
mis2
mis3

@Prakriti-nith
Copy link
Collaborator Author

@Shekharrajak can you please review this example too?

Shekharrajak
Shekharrajak reviewed Aug 15, 2018
View reviewed changes
Copy link
Owner

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am expecting some styling. You can easily use some css framework for it.

demo_rails/app/assets/javascripts/application.js
//= require googlecharts/loader

//= require jquery-latest.min
//= require jquery.dataTables
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line ??

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also comment out about these lines, why it is used. So that people can understand the code easily.

demo_rails/app/views/layouts/multiple_charts_layout.html.erb
@@ -2,11 +2,6 @@
<html>
<head>
<title>Multiple Charts</title>
<%= csrf_meta_tags %>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is removed ?

@Shekharrajak
Copy link
Owner

@Prakriti-nith , any update?

@Shekharrajak
Copy link
Owner

If any other contributor wants to take this task, please go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shekharrajak Shekharrajak Shekharrajak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prakriti-nith @Shekharrajak