[Security] Prototype Pollution in sheetJS #2822

lukewang2018 · 2023-04-27T12:16:35Z

[Security] Prototype Pollution in sheetJS

Affected version: 0.19.3

Description
All versions of SheetJS CE through 0.19.2 are vulnerable to "Prototype Pollution" when reading specially crafted files. Workflows that do not read arbitrary files (for example, exporting data to spreadsheet files) are unaffected.

References
https://nvd.nist.gov/vuln/detail/CVE-2023-30533
https://cdn.sheetjs.com/advisories/CVE-2023-30533
https://git.sheetjs.com/sheetjs/sheetjs/src/branch/master/CHANGELOG.md

mushishi78 · 2023-04-28T16:46:39Z

~~Am I the only one confused that it say it's fixed in 0.19.3 but the latest release of this is 0.18.5?~~

Ah I can see your meant to do yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz. Don't mind me. https://docs.sheetjs.com/docs/getting-started/installation/nodejs

amorimrafael · 2023-05-02T16:35:10Z

Hi guys,

Does anyone know if they have plans to publish this version here on github?

invaderb · 2023-05-02T22:56:11Z

+1 for an update on this?

jimmykane · 2023-05-03T07:26:39Z

Why is this not published to NPM ?

Cellule · 2023-05-03T12:15:29Z

As explained in the Readme, this project is no longer maintained on Github and no longer published to npm.
I don't know the reasons why, but moving forward you are supposed to install using their cdn yarn add xlsx@https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

sheetjs/README.md

Lines 3 to 16 in 5b4806b

    
           > ## 🏠 New Home 
        
           >  
        
           > The new home for SheetJS CE is <https://git.sheetjs.com/sheetjs/sheetjs>, a 
        
           > hosted Gitea instance sponsored by SheetJS LLC.  SheetJS CE remains a truly 
        
           > open source project under the Apache 2.0 License. 
        
           >  
        
           > Issues should be raised at [the new issue tracker](https://git.sheetjs.com/sheetjs/sheetjs/issues). 
        
           > Users can register directly or sign in with a valid GitHub account. 
        
           >  
        
           > [The documentation](https://docs.sheetjs.com/docs/getting-started/#installation) 
        
           > includes instructions for using the new distribution points. 
        
           >  
        
           > Legacy distribution points (including the `SheetJS/sheetjs` Git repository on 
        
           > GitHub and the `xlsx` package on npmjs.com) will not be receiving updates.

Relevant issue as to "why" they no longer publish on npm
https://git.sheetjs.com/sheetjs/sheetjs/issues/2667

I am too a little concerned about how future CVE will be reported and notify users. I feel the switch out of npm didn't take into account security concerns.

Cellule · 2023-05-03T12:57:36Z

Opened another issue on their tracker for future CVE alerting (not explicit of this particular CVE), but more a concern for the future for people switching from NPM to their CDN
https://git.sheetjs.com/sheetjs/sheetjs/issues/2935

invaderb · 2023-05-03T15:34:56Z

That really is piss poor communication on the sheetjs team's part, having it just in their docs is not a wide enough reach to everyone that uses this package, there is nothing in the github readme or on the npm page about essentially the deprecation of the package on npmjs. They should throw up a banner or a message about it, especially for a package that gets 2 million weekly downloads...

I have the same concerns especially about missing out on future security issues with this package now that we have to use the CDN to get updates. I'm also weary about using smaller CDN's, there's a reason why npmjs is the standard and will be around much longer than sheetjs

Just to note for others you don't have to use yarn to install from the CDN you can still use npm or pnpm:
npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

pnpm install https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

Snailedlt · 2023-05-05T10:04:12Z

All the info so far

(please let me know if anything's missing, so I can edit this comment)

Update to the new CDN

npm

npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

pnpm

pnpm install https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

pnpm

yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz

Why you need to update

The GitHub repo and npm packages are no longer maintained due to ongoing legal matters with npm (Owned by GitHub). More info here

…nerability. See SheetJS/sheetjs#2822. Also upgrade Mocha to 10.2.0 to avoid other vulnerabilities mentioned by npm audit.

dafanzhi · 2023-05-24T00:42:30Z

I tried yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz,

then run npm audit, still got the vulnerabilities tips:

what should id do?

Snailedlt · 2023-05-24T01:56:18Z

@dafanzhi seems like you're using npm, and not yarn... So you should use npm install instead of yarn add

dafanzhi · 2023-05-24T16:02:52Z

got the same result via npm:

Snailedlt · 2023-05-24T17:32:15Z

@dafanzhi Did you uninstall the old version?

dafanzhi · 2023-05-24T23:59:46Z

@dafanzhi Did you uninstall the old version?

i've tried removing the old version before reinstall, but still got the same:

As you can see, the problem is the xlsx is already the latest version and installed without any error tips, but the node-xlsx which depends on xlsx can not be installed properly, even i specified the overrides in the package.json:

So, what detailed instructions should i follow to eliminate the vulnerabilities error tips for the xlsx in node-xlsx?

knoxgon · 2023-05-26T07:44:48Z

All the info so far

(please let me know if anything's missing, so I can edit this comment)

Update to the new CDN

npm
npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
pnpm install https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
Why you need to update

The GitHub repo and npm packages are no longer maintained due to ongoing legal matters with npm (Owned by GitHub). More info here

Works Great. Thank you. Although, I wonder... Are there any breaking changes to it? I haven't found any information regarding the release notes...

Zainzzkk · 2023-06-01T21:30:37Z

Does anyone have any other recommendations for similar packages to use instead of SheetJS? Considering the devs won't reply to us anymore, won't implement 2FA to fix this whole issue and nor will they update the npm readme with a notice of this change

lukewang2018 · 2023-06-02T01:13:59Z

@Zainzzkk you can try excel4node.

"excel4node": "^1.8.2",

https://github.com/advisr-io/excel4node

rupeshdeotale97 · 2023-06-28T07:57:12Z

Hi team getting below error for

$ npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
npm ERR! code UNABLE_TO_GET_ISSUER_CERT_LOCALLY
npm ERR! errno UNABLE_TO_GET_ISSUER_CERT_LOCALLY
npm ERR! request to https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz failed, reason: unable to get local issuer certificate

codeams · 2023-07-06T23:44:54Z

Does anyone have any other recommendations for similar packages to use instead of SheetJS? Considering the devs won't reply to us anymore, won't implement 2FA to fix this whole issue and nor will they update the npm readme with a notice of this change

I'm having good results with https://github.com/exceljs/exceljs

e965 · 2023-08-07T17:30:36Z

Hey, folks! I made a little tool that allows you to continue using xlsx in your projects. It checks for updates from the sheetjs selfhosted git repository every day, and if there is a new version there, it is automatically published to npm. The publishing is signed via provenance to prevent extraneous modifications to the project (unless the sheetjs developers themselves come in to sabotage everything, of course).

All code is available for audit here https://github.com/e965/sheetjs-npm-publisher

Installation into your project is also very easy:

- "xlsx": "0.18.5",
+ "xlsx": "npm:@e965/[email protected]",

(or just install the package directly and fix all the imports in your code)

brettwgreen · 2023-08-23T16:17:12Z

I think the truth is they tried to commercialize this project and don't want to support the open source version anymore so they used the lamest excuse possible (NPM is forcing us to use 2FA) to break the open source delivery mechanism and try to squeeze people into using the pro version.

LukasNemcik · 2023-09-25T13:48:17Z

Does anyone have any other recommendations for similar packages to use instead of SheetJS? Considering the devs won't reply to us anymore, won't implement 2FA to fix this whole issue and nor will they update the npm readme with a notice of this change

I'm having good results with https://github.com/exceljs/exceljs

Exceljs is great but it have one for us important flaw - it supports just .XLSX or .CSV formats and doesn't support older .XLS files. So for that reason we are still using also xlsx package.

vasudevaraopaila · 2023-09-27T10:30:46Z

@e965 we are using mat table exporter which is internally using cdk table exporter and dependent on xlsx package, so I have created two dummy npm packages for mat table exporter and cdk table exporter and the installed @e965/xlsx as dependency which replacing xlsx. but I am getting below errors

/node_modules/config-table-exporter/fesm2020/cdk-table-exporter.mjs:130:21-54 - Error: Module not found: Error: Can't resolve 'xlsx/dist/xlsx.mini.min' in 'D:\Projects\Sample_project\Sample_project\node_modules\config-table-exporter\fesm2020'

./node_modules/config-table-exporter/fesm2020/cdk-table-exporter.mjs:132:21-35 - Error: Module not found: Error: Can't resolve 'xlsx' in 'D:\Projects\Sample_project\Sample_project\node_modules\config-table-exporter\fesm2020'

updated all the dependencies and imports from xlsx to @e965/xlsx, but still getting the same. Below are the dummy packages I published

https://www.npmjs.com/package/config-mat-table-exporter?activeTab=code
https://www.npmjs.com/package/config-table-exporter?activeTab=code

mikeplacko · 2023-12-07T15:46:38Z

All the info so far

(please let me know if anything's missing, so I can edit this comment)

Update to the new CDN

npm
npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
pnpm install https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
Why you need to update

The GitHub repo and npm packages are no longer maintained due to ongoing legal matters with npm (Owned by GitHub). More info here

I think it's worth mentioning that their CDN appears to only be using a self-signed certificate, which npm will not like without you jumping through a bunch of hoops. That's a deal breaker for me.

Snailedlt · 2023-12-07T15:51:56Z

@mikeplacko would this answer suit you better? #2822 (comment)

mikeplacko · 2023-12-07T16:29:35Z

@mikeplacko would this answer suit you better? #2822 (comment)

That did work. It did not throw an SSL warning and it seems as legitimate as any other NPM package security wise. Maybe I'm nit picking a bit with the self-signed certificate, but I feel like that's a really low bar to meet in 2023.

basvandorst · 2023-12-12T10:43:41Z

@SheetJSDev could you guys please mark the last package on NPM as deprecated?
https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions

For you guys it's a minute fix but a timesaver for all (thousands of) people that are using your package. Cheers

rap2hpoutre · 2024-02-23T10:44:47Z

Some production networks allow only npmjs.org for repositories. Having an exception like sheetjs.com is not always possible.

bingDBdu · 2024-05-08T08:26:40Z

All the info so far

(please let me know if anything's missing, so I can edit this comment)

Update to the new CDN

npm
npm i https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
pnpm install https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
pnpm
yarn add https://cdn.sheetjs.com/xlsx-0.19.3/xlsx-0.19.3.tgz
Why you need to update

The GitHub repo and npm packages are no longer maintained due to ongoing legal matters with npm (Owned by GitHub). More info here

It looks ugly. I don't like it at all. Hope it's going to be published to NPM as soon as possible.

NoNameProvided · 2024-09-17T12:11:42Z

I have created a script that republishes the package automatically to NPM.

Since the CE edition is licensed under Apache which allows republishing it with proper attribution I have made a small automated script that periodically checks the CDN and republishes the latest version to NPM if needed.

The NPM package can be found here https://www.npmjs.com/package/xlsx-republish.

e965 · 2024-09-17T12:39:02Z

@NoNameProvided competition is wonderful 🙂
#2822 (comment)

NoNameProvided · 2024-09-17T13:41:57Z

Oh, dang, I didn't see that! I came from the above-linked issue and only commented here after I had made my script.

It seems you build from source code which may result in different package content than the actually published artifacts. I have decided to republish the tarball they publish on their own CDN. It ensures you get the exact same content the developers intended. It's a subtle but important difference.

e965 · 2024-09-20T08:20:14Z

@NoNameProvided Yes and no - right now, given that the content of our packages is identical, both of our solutions are correct. But I agree that in the possible future your strategy is more correct.
I'll look into modifying the publish script soon, thanks for the ideas :)

Cellule mentioned this issue May 3, 2023

Update xlsx package because vulnerabilities mgcrea/node-xlsx#189

Closed

robrichardson27 mentioned this issue May 5, 2023

vulnerability in XLSX amcharts/amcharts4#4261

Closed

quigleyj97 mentioned this issue May 6, 2023

Explore SheetJS alternatives quigleyj97/jupyterlab-spreadsheet#61

Open

birgitlewicki mentioned this issue May 8, 2023

Update xlsx library SiLeBAT/mibi-portal-server#344

Closed

amanmahajan7 mentioned this issue May 9, 2023

Remove SheetJS adazzle/react-data-grid#3223

Merged

StefanNedelchev mentioned this issue May 16, 2023

Request: use the latest sheetjs (v0.18.12) gitbrent/xlsx-js-style#17

Open

kevkcc mentioned this issue May 24, 2023

xlsx vulnerability CVE-2023-30533 AlaSQL/alasql#1689

Closed

hakuta mentioned this issue May 29, 2023

update xlsx to 0.19.3 to fix vulnerability LuisEnMarroquin/json-as-xlsx#77

Merged

mathiasrw mentioned this issue May 30, 2023

Include XLSX v0.19.3 as a module AlaSQL/alasql#1694

Merged

saltcod mentioned this issue May 31, 2023

Add lock file supabase/react-data-grid#246

Merged

w3nl mentioned this issue Jun 1, 2023

xlsx package alternative? hckrnews/object-converter#5

Closed

0xverin mentioned this issue Jun 8, 2023

Dependabot warning of xlsx package litentry/litentry-parachain#1637

Closed

luca-drf mentioned this issue Jun 23, 2023

Unable to resolve security vulnerability in mat-table-exporter using npm HalitTalha/ng-material-extensions#181

Open

githubjosh mentioned this issue Jun 23, 2023

Vulnerability found on latest version of json-as-xlsx LuisEnMarroquin/json-as-xlsx#74

Closed

josephjclark mentioned this issue Aug 2, 2023

commcare: Update xlsx dependency OpenFn/adaptors#327

Closed

mtuchi mentioned this issue Aug 3, 2023

commcare update xlsx OpenFn/adaptors#336

Merged

2 tasks

e965 mentioned this issue Aug 7, 2023

Why the move away from npm registry? #2667

Closed

kir12 mentioned this issue Sep 4, 2023

Request to Reduce Size of JavaScript Library > 6MB javascriptdata/danfojs#582

Open

guillaumejparis mentioned this issue Oct 23, 2024

[frontend] Upgrade SheetJS (xlsx) because of vulnerability OpenBAS-Platform/openbas#1731

Merged

imsuvesh mentioned this issue Nov 19, 2024

Archive this GitHub Project #2825

Open

[Security] Prototype Pollution in sheetJS #2822

[Security] Prototype Pollution in sheetJS #2822

Comments

lukewang2018 commented Apr 27, 2023 • edited Loading

mushishi78 commented Apr 28, 2023 • edited Loading

amorimrafael commented May 2, 2023

invaderb commented May 2, 2023

jimmykane commented May 3, 2023

Cellule commented May 3, 2023

Cellule commented May 3, 2023

invaderb commented May 3, 2023

Snailedlt commented May 5, 2023

All the info so far

Update to the new CDN

npm

pnpm

pnpm

Why you need to update

dafanzhi commented May 24, 2023

Snailedlt commented May 24, 2023

dafanzhi commented May 24, 2023

Snailedlt commented May 24, 2023

dafanzhi commented May 24, 2023 • edited Loading

knoxgon commented May 26, 2023

All the info so far

Update to the new CDN

npm

pnpm

pnpm

Why you need to update

Zainzzkk commented Jun 1, 2023

lukewang2018 commented Jun 2, 2023

rupeshdeotale97 commented Jun 28, 2023

codeams commented Jul 6, 2023

e965 commented Aug 7, 2023 • edited Loading

brettwgreen commented Aug 23, 2023

LukasNemcik commented Sep 25, 2023

vasudevaraopaila commented Sep 27, 2023 • edited Loading

mikeplacko commented Dec 7, 2023

All the info so far

Update to the new CDN

npm

pnpm

pnpm

Why you need to update

Snailedlt commented Dec 7, 2023

mikeplacko commented Dec 7, 2023

basvandorst commented Dec 12, 2023

rap2hpoutre commented Feb 23, 2024

bingDBdu commented May 8, 2024

All the info so far

Update to the new CDN

npm

pnpm

pnpm

Why you need to update

NoNameProvided commented Sep 17, 2024

e965 commented Sep 17, 2024

NoNameProvided commented Sep 17, 2024 • edited Loading

e965 commented Sep 20, 2024

lukewang2018 commented Apr 27, 2023 •

edited

Loading

mushishi78 commented Apr 28, 2023 •

edited

Loading

dafanzhi commented May 24, 2023 •

edited

Loading

e965 commented Aug 7, 2023 •

edited

Loading

vasudevaraopaila commented Sep 27, 2023 •

edited

Loading

NoNameProvided commented Sep 17, 2024 •

edited

Loading