Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on NODE_NO_HTTP2 = 1 #3144

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Conversation

StfBauer
Copy link
Collaborator

Remark what need to be done to be able to launch local workbench especially for SharePoint 2016 projects.

Category

  • Content fix
  • New article
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Additional remark for web part development that targets on-premises environments

Remark what need to be done to be able to launch local workbench especially for SharePoint 2016 projects.
@spdevdocs
Copy link
Contributor

OPS Build status updates of commit 4cb14cb:

🕙 Preparing: average preparing time is 1 min(s) 7 sec(s)

@spdevdocs
Copy link
Contributor

OPS Build status updates of commit 4cb14cb:

🕙 Incremental building: average incremental building time is 46 sec(s)

@spdevdocs
Copy link
Contributor

OPS Build status updates of commit 4cb14cb:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/set-up-your-development-environment.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@andrewconnell
Copy link
Collaborator

@StfBauer Looks like a typo in the submission "I case" => "In case"...

But I'd also provide more detail than just this paragraph... I suspect most people don't understand what's up in this scenario. Maybe just reference a clear closed issue so people can see additional details as to the WHY. I don't think we want to provide too much detail here as it can get confusing.

@StfBauer
Copy link
Collaborator Author

Thanx @andrewconnell - In this case, we may refer to #1002 - It has many details and the complete history in it. What do you think?

@andrewconnell
Copy link
Collaborator

Agreed... I'd try to provide as little info as possible in the update to the docs. More info about edge cases can confuse people who aren't as experienced with Node.js... less is more.

@VesaJuvonen VesaJuvonen merged commit d425a5c into SharePoint:master Dec 28, 2018
@VesaJuvonen
Copy link
Contributor

Let's not, however, add a reference to the issue itself, as that might freak out people even more... In best case scenario we would have specific on-prem guidance around setting things up and not combine both, but as that does not exist, let's add this note on the article and keep as such for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants