Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Formatting - Issue using inline edit and setValue in "customCardProps" #9614

Open
2 of 9 tasks
aaclage opened this issue Apr 2, 2024 · 6 comments
Open
2 of 9 tasks
Labels
Needs: Triage 🔍 Awaiting categorization and initial review. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.

Comments

@aaclage
Copy link

aaclage commented Apr 2, 2024

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

Declarative list formatting

Developer environment

None

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

Browser

Describe the bug / error

Dear Mr. @shagra-ms,
I would like to report the following issue and inconsistent behavior when using some actions in List View but not when using WebPart List in SharePoint Page:

  • Cannot make field inline edit when using "customCardProps"
  • Cannot use "setValue" to update value and refresh when using "customCardProps"

ErrorListFormatting

Steps to reproduce

  1. Create support List
  2. Add Columns "Title" and "Description"
  3. Create List Include following List Formatting on View:
{
  "$schema": "https://developer.microsoft.com/json-schemas/sp/v2/row-formatting.schema.json",
  "hideColumnHeader": true,
  "hideSelection": true,
  "rowFormatter": {
    "elmType": "button",
    "style": {
      "margin": "10px",
      "padding": "20px"
    },
    "txtContent": "Click here",
    "customCardProps": {
      "openOnEvent": "click",
      "formatter": {
        "elmType": "div",
        "style": {
          "padding": "20px"
        },
        "children": [
          {
            "elmType": "div",
            "style": {
              "padding": "10px"
            },
            "children": [
              {
                "elmType": "div",
                "style": {
                  "padding": "10px",
                  "font-size": "20px",
                  "border": "1px solid black",
                  "cursor": "pointer"
                },
                "attributes": {
                  "iconName": "WavingHand"
                },
                "txtContent": "Click me to open 2 dialog",
                "customCardProps": {
                  "openOnEvent": "click",
                  "formatter": {
                    "elmType": "div",
                    "children": [
                      {
                        "elmType": "div",
                        "style": {
                          "padding": "10px",
                          "font-size": "20px",
                          "border": "1px solid black",
                          "cursor": "pointer"
                        },
                        "attributes": {
                          "iconName": "WavingHand"
                        },
                        "txtContent": "Click me again",
                        "customRowAction": {
                          "action": "setValue",
                          "actionInput": {
                            "Title": "=Number(@now)"
                          }
                        }
                      }
                    ]
                  }
                }
              },
              {
                "elmType": "div",
                "style": {
                  "padding": "10px",
                  "font-size": "15px",
                  "font-weight": "bold"
                },
                "txtContent": "Title:"
              },
              {
                "elmType": "div",
                "style": {
                  "padding": "10px"
                },
                "txtContent": "[$Title]"
              },
              {
                "elmType": "div",
                "style": {
                  "padding": "10px",
                  "font-size": "15px",
                  "font-weight": "bold"
                },
                "txtContent": "Description:"
              },
              {
                "elmType": "div",
                "style": {
                  "padding": "10px"
                },
                "txtContent": "[$Description]",
                "inlineEditField": "[$Description]"
              }
            ]
          }
        ]
      }
    }
  }
}

4- Create SharePoint Page
5- Add WebPart List with new View
6- Test options on support gif

Expected behavior

The gif below provide current behavior when List is View mode and List is included in SharePoint Page but behavior is not the same as shown in image bellow.
It's expected that same functionalities should be able to work on both sides.
ErrorListFormatting

@aaclage aaclage added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Apr 2, 2024
@VesaJuvonen VesaJuvonen added the Needs: Triage 🔍 Awaiting categorization and initial review. label Apr 3, 2024
@shagra-ms
Copy link
Contributor

@aaclage we are currently looking into this.

@aaclage
Copy link
Author

aaclage commented Jun 24, 2024

Dear @shagra-ms @arkogupta,

Thank you for the update, here my feedback on current status:

1- inlineEditField was fixed
2- setValue in customCardProps was not fixed

Hope second point can also be fixed, again thank you for your support.
A L

@aaclage
Copy link
Author

aaclage commented Aug 8, 2024

Dear Mr. @tpodugu-ms, @shagra-ms, @arkogupta,

Report issue
2- setValue in customCardProps

Tested capability to update on modal dialog based on sample and is working now.

I will close ticket.

Thank you for your support,
AL

@aaclage
Copy link
Author

aaclage commented Oct 31, 2024

Dear @tpodugu-ms, @shagra-ms, @arkogupta,

I use the following base as described here and issue returns, looks like a roolback or something.
Should create new ticket or should keep this one?

@aaclage aaclage reopened this Oct 31, 2024
@aaclage
Copy link
Author

aaclage commented Nov 19, 2024

Dear @tpodugu-ms, @shagra-ms, @arkogupta,

Can you validate this issue also return from your side?

@tpodugu-ms
Copy link

Hi @aaclage, Thanks for following up. I will check this and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Awaiting categorization and initial review. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

4 participants