Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review handling of time. #70

Open
vvorski opened this issue Dec 3, 2013 · 24 comments
Open

Review handling of time. #70

vvorski opened this issue Dec 3, 2013 · 24 comments
Assignees

Comments

@vvorski
Copy link
Member

vvorski commented Dec 3, 2013

we have to think through more carefully the handling of time:

  • time can never be returned only given
  • we keep a track of the balance of time between the two sides.
  • need to think how to display this time balance on the address-book view.
  • input as minutes (15/30/45?), hours, days

screens to be updated

on friend detail page need:

  • link to their facebook page
  • how much time I've given them
  • how much time I've received from them
  • time balance display
@ghost ghost assigned konewa Dec 3, 2013
@ghost ghost assigned rimbambala Jan 27, 2014
@konewa
Copy link

konewa commented Jan 27, 2014

@rimbambala design?

@rimbambala
Copy link

I was thinking of showing time balance in a profile view rather then in address book. In address book we have very limited space for anything else. I will prepare the design in profile view if you like this solution.

@ghost ghost assigned vvorski Jan 28, 2014
@vvorski
Copy link
Member Author

vvorski commented Jan 29, 2014

@rimbambala Hmmm. I want to make the idea of time sharing as a key concept of this app. In a lot of ways it is the most imporant part of the whole Share❣ concept...

But maybe you are right putting the whole amount display on this screen won't fit.

How about just an indicator on the person's photo icon that you have some timesharing with them?
Then the details on the profile view as you suggest.

@ghost ghost assigned konewa Jan 29, 2014
@vvorski vvorski assigned rimbambala and unassigned konewa Mar 21, 2014
@vvorski
Copy link
Member Author

vvorski commented Mar 21, 2014

agreed will design, in friends list only show hours... maybe visual display...

@rimbambala
Copy link

  • input as minutes (15/30/45?), hours, days
    as we agreed it would be basically hours and optional minutes.

My proposition for UI would be:

web app - simple combobox

Android devices - second dialog form the screen - http://developer.android.com/design/media/dialogs_examples.png

iOS devices - Picker from the screen - https://developer.apple.com/library/ios/documentation/userexperience/conceptual/MobileHIG/Art/picker_2x.png

Hours range 1 to 24, minutes range 0, 15, 30, 45

@vvorski
Copy link
Member Author

vvorski commented Mar 24, 2014

How will the system picker look in our design? Is there an option for a skinned control?

@konewa
Copy link

konewa commented Mar 24, 2014

@rafallo ?

@rafallo
Copy link
Contributor

rafallo commented Mar 24, 2014

On iOS we can show native date picker and now it works that way.
Android devices are not able to use native date picker in browser so we have to use something Javascript based.

@rimbambala
Copy link

Maybe in case of android we can use a simple popup/modal just like the one used for filtering or language change

@rimbambala rimbambala assigned konewa and rimbambala and unassigned rimbambala and konewa Mar 25, 2014
@vvorski
Copy link
Member Author

vvorski commented Mar 27, 2014

  • on listing page only show hours
  • on detail page show hours and minutes.

@rimbambala
Copy link

Listing page means address book / friend list?

@rimbambala rimbambala assigned vvorski and unassigned rimbambala Apr 1, 2014
@vvorski
Copy link
Member Author

vvorski commented Apr 1, 2014

@rimbambala listing page is friends list - handled in #22 so that leaves:

  • friend detail
  • create time share
  • time share detail
  • timeline (same as timeshare detail or different?)

@vvorski vvorski assigned rimbambala and unassigned vvorski Apr 1, 2014
@konewa konewa assigned rimbambala and unassigned rimbambala Apr 1, 2014
@vvorski
Copy link
Member Author

vvorski commented Apr 1, 2014

on friend detail page need:

  • link to their facebook page
  • how much time I've given them
  • how much time I've received from them
  • time balance display

@rimbambala
Copy link

Create Time Share
share-newtimeshare-step2-12

Timeline time share view (no photo; if photo is present here timeshare will look just as other ones - the only difference is that we are showing time given/received)
share-06f

Time share detail would be just like detailed thing/promise share

@vvorski
Copy link
Member Author

vvorski commented Apr 5, 2014

Ok, except need to also be able to input text with time - same as others photo or text or both...

Note new suggested create dialog layout in #65.

@vvorski
Copy link
Member Author

vvorski commented Apr 5, 2014

  • also what will the time selection look like when clicked. are we going to use a custom selector?

@rimbambala
Copy link

share-newtimeshare-step2-13
New share with "add text" feature

In case of time selection my proposal was:

My proposition for UI would be:

web app - simple combobox

Android devices - second dialog form the screen - http://developer.android.com/design/media/dialogs_examples.png

iOS devices - Picker from the screen - https://developer.apple.com/library/ios/documentation/userexperience/conceptual/MobileHIG/Art/picker_2x.png

Everything depends on development possibility. Correct me if I'm wrong, I think @rafallo said that it might be impossible for picker to be incorporated as far as Android devices are concerned. In that case we can use the first dialog from this link:
http://developer.android.com/design/media/dialogs_examples.png

We can than style it as any other modal in the application. E.g.
share-06-language

Every modal should be design in similar theme.

@rimbambala
Copy link

share-07-profileview

@rimbambala rimbambala assigned vvorski and unassigned rimbambala Apr 8, 2014
@vvorski
Copy link
Member Author

vvorski commented Apr 9, 2014

Detail page we should simplify and use that icon from the listing page (#22) also let's see if we can add to the icon indicator for whether we received or gave, something based on hands perhaps?

  • hands up I am in plus - I am giving
  • hands down/around bottom - I am receiving

person-profile

@vvorski
Copy link
Member Author

vvorski commented Apr 9, 2014

For time input wouldn't we be better off using our own controls? The system controls look very different from our UI...

@vvorski vvorski assigned rimbambala and unassigned vvorski Apr 9, 2014
@rimbambala
Copy link

share-08-profileview

@rimbambala rimbambala assigned vvorski and unassigned rimbambala Apr 10, 2014
@vvorski
Copy link
Member Author

vvorski commented Apr 11, 2014

What about:

  • indication of giving/receiving on the icon?

@vvorski vvorski assigned rimbambala and unassigned vvorski Apr 11, 2014
@rimbambala
Copy link

share-08-profileview

@rimbambala rimbambala assigned vvorski and unassigned rimbambala Apr 14, 2014
@vvorski
Copy link
Member Author

vvorski commented Apr 15, 2014

@konewa ok let's just go with this for now... need to implement and launch...

@vvorski vvorski assigned konewa and unassigned vvorski Apr 15, 2014
@vvorski vvorski assigned vvorski and unassigned konewa Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants