Merge pull request bitcoin#2246 from gavinandresen/changefix

Correctly randomize change output position
ShadowOfHarbringer · Jan 30, 2013 · a078121 · a078121
2 parents db3b4ad + ac7b8ea
commit a078121
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/wallet.cpp b/src/wallet.cpp
@@ -1190,7 +1190,7 @@ bool CWallet::CreateTransaction(const vector<pair<CScript, int64> >& vecSend, CW
                     scriptChange.SetDestination(vchPubKey.GetID());
 
                     // Insert change txn at random position:
-                    vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size());
+                    vector<CTxOut>::iterator position = wtxNew.vout.begin()+GetRandInt(wtxNew.vout.size()+1);
                     wtxNew.vout.insert(position, CTxOut(nChange, scriptChange));
                 }
                 else