Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guide names to allow checkout on windows #223

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

djak250
Copy link
Contributor

@djak250 djak250 commented Jun 5, 2024

Checking out this project on a windows computer causes a load of issues, due to the guides having : in the name. This rename fixes that issue.

@SgtBatten SgtBatten merged commit dedad0e into SgtBatten:main Jun 5, 2024
@djak250
Copy link
Contributor Author

djak250 commented Nov 12, 2024

@SgtBatten I just want to make sure that you remember to merge/rebase this change into the #216 branch so it doesn't re-break the paths for windows again if that merge overwrites this change when it's merged to main.

@SgtBatten
Copy link
Owner

I'm not great with github, if that's achievable, yes i will. My plan A was to abandon the pull request when its ready and copy the changed file into main branch as a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants