Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: Migrate all zstd compression to minimized frame size format. #19

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Sewer56
Copy link
Owner

@Sewer56 Sewer56 commented Dec 7, 2024

See the updated 'overview' section in the PR for the details.
We're basically trimming off 10 bytes per zstd compressed block :p

@Sewer56 Sewer56 self-assigned this Dec 7, 2024
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (3178bd0) to head (ca50913).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...er56-archives-nx/src/utilities/compression/zstd.rs 82.35% 9 Missing ⚠️
...er56-archives-nx/src/headers/parser/string_pool.rs 95.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   82.68%   82.74%   +0.05%     
==========================================
  Files          71       71              
  Lines        2506     2532      +26     
==========================================
+ Hits         2072     2095      +23     
- Misses        434      437       +3     
Flag Coverage Δ
unittests 82.74% <86.11%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/headers/parser/dictionary/dictionary_builder.rs 76.31% <ø> (ø)
...chives-nx/src/headers/parser/string_pool_common.rs 85.18% <ø> (ø)
...chives-nx/src/utilities/compression/zstd_stream.rs 92.30% <100.00%> (+0.30%) ⬆️
...er56-archives-nx/src/headers/parser/string_pool.rs 87.58% <95.00%> (-0.09%) ⬇️
...er56-archives-nx/src/utilities/compression/zstd.rs 85.16% <82.35%> (+1.94%) ⬆️

... and 1 file with indirect coverage changes

@Sewer56 Sewer56 merged commit 975b2e8 into main Dec 7, 2024
28 checks passed
@Sewer56 Sewer56 deleted the zstd-bare-frames branch December 7, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant