fix panic while unmarshaling into object.BaseLinkRating (#256)

SevereCloud · Oct 3, 2023 · b2ba2c4 · b2ba2c4
1 parent 7136f3f
commit b2ba2c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/object/object.go b/object/object.go
@@ -285,8 +285,8 @@ type BaseLinkProduct struct {
 
 // BaseLinkRating struct.
 type BaseLinkRating struct {
-	ReviewsCount int     `json:"reviews_count"`
-	Stars        float64 `json:"stars"`
+	ReviewsCount json.Number `json:"reviews_count"`
+	Stars        float64     `json:"stars"`
 }
 
 // BasePlace struct.

diff --git a/object/object_test.go b/object/object_test.go
@@ -2,6 +2,7 @@ package object_test
 
 import (
 	"bytes"
+	"encoding/json"
 	"reflect"
 	"testing"
 
@@ -320,3 +321,13 @@ func TestBaseSticker_MinSizeBackground(t *testing.T) {
 		Width: 10, Height: 20,
 	})
 }
+
+func TestBaseLinkRating_UnmarshalJSON(t *testing.T) {
+	ratingJSON := []byte(`{"reviews_count":1.0,"stars":5.0}`)
+	var rating object.BaseLinkRating
+
+	assert.NoError(t, json.Unmarshal(ratingJSON, &rating))
+	review, _ := rating.ReviewsCount.Float64()
+	assert.Equal(t, 1.0, review)
+	assert.Equal(t, 5.0, rating.Stars)
+}