Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mapping type from search fields. #3

Closed

Conversation

jfcantu
Copy link

@jfcantu jfcantu commented Mar 18, 2020

Removes mapping type as a search parameter when querying alert logs.

Mapping types were removed in ElasticSearch 7.x, and attempting to search by mapping type will prevent results from being returned.

@nsano-rururu
Copy link

We have confirmed that applying this solution also solves the problem. Thank you for your support. I hope that it will be incorporated into the main body as soon as possible.

@johnsusek
Copy link

@jfcantu The new repo going forwarding for praeco will be https://github.com/johnsusek/elastalert-server. Can you please put this PR into that fork? I could make this change but I would prefer you get credit.

@johnsusek
Copy link

Also, will this still work with ES5/6 ? Maybe there should be a version check around this logic

@jfcantu
Copy link
Author

jfcantu commented Jun 8, 2020

@johnsusek Will do! Before I do, I'll review my code and check the compatibility.

@johnsusek
Copy link

johnsusek commented Jun 13, 2020

Ended up getting this change into https://github.com/johnsusek/elastalert-server today, which praeco master now points to. A new release for praeco is coming shortly with these changes, thanks. I no longer have permissions to close PRs in this repo, so you can close this. I'll mention you in the praeco readme.

@joshbasho
Copy link

joshbasho commented Aug 17, 2020

@jfcantu any chance you could put your docker image up as a repo?

There's a bug in Praeco's elastalert-server. The workaround is to use this elastalert-server image, which is based on jfcantu/elastalert. Would like to bump the Elastalert version in it up and see if I can figure out what's different so it can be integrated into praeco image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants