Assert in crc8::validate that buffer size is a multiple of 3 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously crc8::validate would only panic in debug builds, but not in release builds when passing in buffers with a size which isn't a multiple of 3. In release builds the remaining bytes just wouldn't get validated. Fixes #10
rnestler
force-pushed
the
always-panic-in-crc8-validatge
branch
from
c84b42c
to
24cfc96
Compare
psachs
approved these changes
Sep 1, 2020
rnestler
added a commit
that referenced
this pull request
Sep 2, 2020
Previously it would only panic in debug builds to match the behaviour of crc8::validate. But since we changed that in #13 it makes sense to adapt here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously crc8::validate would only panic in debug builds, but not in
release builds when passing in buffers with a size which isn't a
multiple of 3. In release builds the remaining bytes just wouldn't get
validated.
Fixes #10