Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning to conditioning #7

Merged
merged 1 commit into from
May 21, 2024
Merged

add warning to conditioning #7

merged 1 commit into from
May 21, 2024

Conversation

sdmueller
Copy link
Contributor

add warning to:

  • Example Usages
  • Function description (gets pulled into docs/quickstart)

LeonieFierz
LeonieFierz requested changes May 16, 2024
View reviewed changes
Copy link
Member

@LeonieFierz LeonieFierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the note to the README as you did for the others.

@sdmueller
add warning to conditioning
9802fd3 
add warning to:
- Example Usages
- Function description (gets pulled into docs/quickstart)
@sdmueller sdmueller force-pushed the add_conditioning_warning branch from f510cc5 to 9802fd3 Compare May 21, 2024 06:32
@sdmueller
Copy link
Contributor Author

I would add the note to the README as you did for the others.

missed that one, thanks!

@sdmueller sdmueller requested a review from LeonieFierz May 21, 2024 06:34
@sdmueller sdmueller merged commit d25cee9 into master May 21, 2024
13 checks passed
@sdmueller sdmueller deleted the add_conditioning_warning branch May 21, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonieFierz LeonieFierz LeonieFierz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdmueller @LeonieFierz