This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Fix SCD30 buffer overflow, update embedded-common #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrauchli
force-pushed
the
fix-buffer-overflow
branch
from
cd47009 to
5a078eb
Compare
* Fix a buffer overflow due to specifing the number of bytes instead of the number of words. * Use renamed methods from embedded-common that reflect that a size in words is assumed. Closes #32 Many thanks to @monkeytronics for finding and reporting the issue
abrauchli
force-pushed
the
fix-buffer-overflow
branch
from
5a078eb to
391aaa7
Compare
rnestler
reviewed
Oct 31, 2019
rnestler
approved these changes
Oct 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the following:
make style-fix)