-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 817 added Footer to DesktopHeader and MobileHeader #964
Conversation
Deployment failed with the following error:
|
Merge conflict here, let's fix that before we review. |
Do we want a link for the CDOT website on the footer? |
Code wise I think it's fine, however because of #962, where would we put the footer when the drawer is removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, this looks good to me. The sidebar is shaping up great.
Oh this is a good idea! |
Thinking ahead, we should keep the drawer because after I finish #290 , I wanna add another tab that says DOCS underneath ABOUT. But #290 will probably done in May... This is up for discussion. Do we wanna remove the drawer for a month and reintroduce it after? Or just keep it? There are plenty of new pages we can add in the future |
added link to Seneca CDOT website :) |
Issue This PR Addresses
Fixes #817
Type of Change
Description
Initially meant to put this Footer underneath all the blog posts but I notice that after we hit the last blog post, it actually continues to load more blog posts so it doesn't make sense to put the footer there. This adds Footers to the bottom of the side drawer for both the DesktopHeader and MobileHeader.
Checklist