set trust for first proxy when env is prod

[sfrunza13]

Issue This PR Addresses

Fixes #3792

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

I am trying to find a way to make the new cookie settings work, perhaps this might be a step in the right direction.

Steps to test the PR

Checklist

• Quality: This PR builds and passes our npm test and works locally (but it only changes anything in prod so idk if this means anything)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[humphd]

From the docs:

Number: use the address that is at most n number of hops away from the Express application. req.socket.remoteAddress is the first hop, and the rest are looked for in the X-Forwarded-For header from right to left. A value of 0 means that the first untrusted address would be req.socket.remoteAddress, i.e. there is no reverse proxy.When using this setting, it is important to ensure there are not multiple, different-length paths to the Express application such that the client can be less than the configured number of hops away, otherwise it may be possible for the client to provide any value.

We are behind 2 proxies:

1. nginx
2. traefik

I wonder if this should be 2? I'm not sure.

[sfrunza13]

I suppose you're right, it should probably be 2

[humphd]

I think this is good. @manekenpix, do you have any concerns?

[manekenpix]

I think this is good. @manekenpix, do you have any concerns?

@humphd LGTM 👍

[sfrunza13]

Can I squash and merge?

[manekenpix]

@sfrunza13 I think this is good to go.

[humphd]

@sfrunza13 yeah, go for it