Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3604: Announce Sign-Ups in Slack #3773

Merged
merged 38 commits into from
Dec 3, 2022
Merged

Closes #3604: Announce Sign-Ups in Slack #3773

merged 38 commits into from
Dec 3, 2022

Conversation

SerpentBytes
Copy link
Contributor

@SerpentBytes SerpentBytes commented Nov 29, 2022 •
edited by manekenpix
Loading

Issue This PR Addresses

Closes #3604

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR implements the enhancement requested in #3604.

Steps to test the PR

  • Replace the constants in env.* files with actual credentials. For CHANNEL_ID, use your member id.
  • Start Telescope
  • Create an account
  • Check for a DM from telescope-bot

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Behaviour

Screenshot 2022-12-01 at 9 21 24 AM

@gitpod-io
Copy link

gitpod-io bot commented Nov 29, 2022

@SerpentBytes SerpentBytes marked this pull request as draft November 29, 2022 22:27
@SerpentBytes SerpentBytes changed the title Initial implementation for #3604 Closes #3604: Announce Sign-Ups in Slack Nov 29, 2022
@manekenpix manekenpix added the area: sso Authentication label Nov 29, 2022
@SerpentBytes SerpentBytes marked this pull request as ready for review December 1, 2022 00:02
@SerpentBytes SerpentBytes marked this pull request as draft December 1, 2022 00:05
humphd
humphd requested changes Dec 1, 2022
View reviewed changes
src/api/sso/src/middleware.js Outdated Show resolved Hide resolved
src/api/sso/src/slack-bolt-client.js Outdated Show resolved Hide resolved
@SerpentBytes
Copy link
Contributor Author

SerpentBytes commented Dec 1, 2022 •
edited
Loading

@humphd I have updated the code based on feedback. Also, I have included the link to the blog URL associated with the user. The code is optional, so it does not cause SSO to crash. All tests are passing now.

See below:

Screenshot 2022-12-01 at 9 21 24 AM

@SerpentBytes SerpentBytes requested review from humphd and manekenpix and removed request for manekenpix and humphd December 1, 2022 14:25
@manekenpix manekenpix merged commit ce522b3 into Seneca-CDOT:master Dec 3, 2022
@SerpentBytes SerpentBytes deleted the issue-3604 branch December 3, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@humphd humphd humphd left review comments

Assignees

@SerpentBytes SerpentBytes

Labels
area: sso Authentication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Announce Sign-Ups in Slack
3 participants
@SerpentBytes @humphd @manekenpix