Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 'About Us' wrong hyperlink #3767

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

Ririio
Copy link
Contributor

@Ririio Ririio commented Nov 17, 2022

Issue This PR Addresses

Fixes #3758

Type of Change

UI: Fix issue regarding wrong hyperlink for "About Us"

Description

The value provided for the hyperlink of the "About Us" on the navigation bar was pointing to an already publicized version of itself instead of the component it has within the repository, this is shown from the image below

Image description

Once the value has been changed, you can see the the hyperlink now points at the actual component of repository, as seen from the image below

image

Steps to test the PR

  1. Start the developer's tool of your local repository
  2. Look fo the "React Component" section, and click the "Select Element" Icon
  3. Click on the "About Us" section, and view the href to see if the value is "/docs/overview/"

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 17, 2022

P-DR0ZD
P-DR0ZD previously approved these changes Nov 17, 2022
Copy link
Contributor

@P-DR0ZD P-DR0ZD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@humphd
Copy link
Contributor

humphd commented Nov 18, 2022

Please don't merge master into your branch. Use a rebase.

Kevan-Y
Kevan-Y previously approved these changes Nov 18, 2022
@Ririio
Copy link
Contributor Author

Ririio commented Nov 18, 2022

Please don't merge master into your branch. Use a rebase.

How should I do this?

@NeilAn99
Copy link
Contributor

The changes work as intended, good find. If you are having trouble with rebase like I did, here's what someone told me to do:

It looks like you are doing merge instead. Can you walk us through what you do to squash, rebase, and push? While in the issue branch, I usually do git rebase main -i to squash, git rebase main for rebase, and git push origin issue-xxx --force to force push the rebased/squashed commit.

Kevan-Y
Kevan-Y previously approved these changes Nov 20, 2022
@humphd
Copy link
Contributor

humphd commented Nov 20, 2022

@Ririio can you squash/rebase this so we can merge?

@Ririio
Copy link
Contributor Author

Ririio commented Nov 20, 2022

@Ririio can you squash/rebase this so we can merge?

I thought I already squash/rebase it from this commit from a couple days ago?

image

@humphd
Copy link
Contributor

humphd commented Nov 20, 2022

Why do you have 2 commits then? Squash means "1 commit."

@Ririio
Copy link
Contributor Author

Ririio commented Nov 20, 2022

Why do you have 2 commits then? Squash means "1 commit."

Oh it must have been when I click then "update branch", I'll force the rebase when I get back home

@Kevan-Y
Copy link
Contributor

Kevan-Y commented Nov 22, 2022

Branch still not up to date based on GitHub

@manekenpix manekenpix merged commit ccc02f9 into Seneca-CDOT:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About & "About us" different hyperlinks
6 participants