-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 'About Us' wrong hyperlink #3767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Please don't merge |
How should I do this? |
The changes work as intended, good find. If you are having trouble with rebase like I did, here's what someone told me to do:
|
@Ririio can you squash/rebase this so we can merge? |
I thought I already squash/rebase it from this commit from a couple days ago? |
Why do you have 2 commits then? Squash means "1 commit." |
Oh it must have been when I click then "update branch", I'll force the rebase when I get back home |
Branch still not up to date based on GitHub |
Fixing ESLint issues
Issue This PR Addresses
Fixes #3758
Type of Change
UI: Fix issue regarding wrong hyperlink for "About Us"
Description
The value provided for the hyperlink of the "About Us" on the navigation bar was pointing to an already publicized version of itself instead of the component it has within the repository, this is shown from the image below
Once the value has been changed, you can see the the hyperlink now points at the actual component of repository, as seen from the image below
Steps to test the PR
href
to see if the value is "/docs/overview/"Checklist