-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update environment-setup.md #3762
Conversation
Hey @P-DR0ZD, I'd recommend you to change these lines to the docs as it's more accurate to what we solved yesterday. Change these telescope/src/web/docusaurus/docs/getting-started/environment-setup.md Lines 291 to 293 in 3073184
to Stop the `parser` service running. Make sure to stop the `parser` container before continuing to the next step by either using
Docker Desktop app:
![image](https://user-images.githubusercontent.com/58532267/202260945-30cc22f1-a634-4d4c-9d21-55824fd6bb5a.png)
Docker CLI: `docker stop <container-id>` (e.g, `15649f07c6bf` in above picture)
Switch to app's `.env` by `cp ./config/env.development ./.env` (you changed `.env` previously to seed database).
Finally, restart the `parser` container by running `pnpm:services start parser`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost ready, just one more change and I think it'll be good to go in.
- I tested it and the build fails because the path to the image is wrong. It should be:
../../static/img/initialProjectDiagram.png
(it's missing another../
).
And since we're changing the path, can we give the image a different name? what's displaying is definitely not the "Initial Project Diagram".
Also, if you want to test your changes, go to the folder src/web/docusarus
and run first pnpm build
and then pnpm serve
. After that, you should be able to access your local docusaurus in a browser.
Thanks for this PR. I could set up my local to fix my issue based on this updated document. It's not relevant to this issue, but perhaps you could also update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, one other issue needs to be addressed (I mentioned it in another comment) and we're good here.
The issue:
And since we're changing the path, can we give the image a different name? what's displaying is definitely not the "Initial Project Diagram".
Added some extra info to help prevent user errors
Co-authored-by: David Humphrey <[email protected]>
Co-authored-by: David Humphrey <[email protected]>
Added Suggested Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Added some extra info to help prevent user errors
Issue This PR Addresses
Type of Change
Description
Steps to test the PR
Checklist