Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto select feed if only one exists #3751

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Nov 1, 2022

Issue This PR Addresses

Fixes #3687

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

During the signup process, after the user enters their blog URL and clicks Validate Blog, it shows a list of possible feed URLs.
If only one feed URL is returned, it should get selected automatically

Steps to test the PR

  • Follow the setup instructions to setup login (if testing locally)
  • Navigate to telescope homepage, and click on sign up
  • Follow the prompts until you reach the Blog URL form
  • Enter a Blog URL for which only one Feed URL exists and click 'Validate Blog'
  • Check that Feed URL is automatically selected
  • Repeat the above with a Blog URL for which there are multiple feed URLs and click 'Validate Blog'
  • Check that no feed URL is automatically checked

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 1, 2022

@humphd
Copy link
Contributor

humphd commented Nov 1, 2022

This is marked "draft." When you're ready for review, let us know.

@Eakam1007 Eakam1007 marked this pull request as ready for review November 3, 2022 16:46
@humphd
Copy link
Contributor

humphd commented Nov 3, 2022

@Eakam1007 don't merge master into your branch, please rebase and squash.

@Eakam1007
Copy link
Contributor Author

@Eakam1007 don't merge master into your branch, please rebase and squash.

Oh sorry. I will rebase

Set value instead of calling handleCheck function
Copy link
Member

@manekenpix manekenpix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

1 feed:
image

more than 1 feed:
image

@manekenpix manekenpix merged commit 960b262 into Seneca-CDOT:master Nov 9, 2022
mnosov622 pushed a commit to mnosov622/telescope that referenced this pull request Nov 11, 2022
liutng pushed a commit to liutng/telescope that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-select feed in sign-up if only one is available
3 participants