Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3713 update engine to node.js 16 and deps for planet service #3726

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Fixes #3713 update engine to node.js 16 and deps for planet service #3726

merged 1 commit into from
Oct 21, 2022

Conversation

cindyorangis
Copy link
Contributor

Issue This PR Addresses

Fixes #3713

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@cindyorangis cindyorangis self-assigned this Oct 21, 2022
@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2022

humphd
humphd approved these changes Oct 21, 2022
View reviewed changes
src/api/planet/package.json
@@ -22,17 +22,17 @@
"dependencies": {
"@senecacdot/satellite": "^1.28.0",
"@supabase/supabase-js": "1.29.4",
"express": "4.17.3",
"express": "4.18.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue to do this in Satellite too? I'm assuming it needs it as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

@cindyorangis cindyorangis merged commit 1dfb6d8 into Seneca-CDOT:master Oct 21, 2022
@cindyorangis cindyorangis mentioned this pull request Oct 21, 2022
Closed
@cindyorangis cindyorangis added the dependencies Pull requests that update a dependency file label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

Assignees

@cindyorangis cindyorangis

Labels
area: microservices dependencies Pull requests that update a dependency file hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planet Service needs to be upgraded from Node.js 12 to Node.js 16
2 participants
@cindyorangis @humphd