Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade xterm dep as a bandaid fix for status dashboard build #3723

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

cindyorangis
Copy link
Contributor

Issue This PR Addresses

Fixes #3720

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

So the upgrade of xterm v5 dependencies in #3718 broke our build log page in the dashboard. Downgrading it back to v4 should fix the issue.

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@cindyorangis cindyorangis added dependencies Pull requests that update a dependency file hacktoberfest-accepted area: dashboard Related to Telescope's dashboard (the page that has stats) labels Oct 20, 2022
@cindyorangis cindyorangis self-assigned this Oct 20, 2022
@gitpod-io
Copy link

gitpod-io bot commented Oct 20, 2022

@manekenpix manekenpix merged commit ec80669 into Seneca-CDOT:master Oct 20, 2022
liutng pushed a commit to liutng/telescope that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats) dependencies Pull requests that update a dependency file hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telescope build page stuck loading
2 participants