Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dependency Page CSS #3702

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Improve Dependency Page CSS #3702

merged 1 commit into from
Oct 31, 2022

Conversation

Eakam1007
Copy link
Contributor

@Eakam1007 Eakam1007 commented Oct 9, 2022 •
edited
Loading

Issue This PR Addresses

Fixes #3535

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Updated the CSS for the dependency page table to make dependencies stand out more:

  • Increased font size for dependency names
  • Changed font family to Spartan
  • Also changed the color of the border separating dependencies so it is not as bright in dark mode

No tests were added since this is a small css change.

Current:
image
image

Updated:
image
image

Steps to test the PR

  • Run telescope locally
  • Navigate to /dependencies
  • Check the updated styles for dependency names and the border for both light theme and dark theme

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Oct 9, 2022

@humphd humphd requested review from JerryHue and Kevan-Y October 11, 2022 14:17
@Eakam1007 Eakam1007 requested review from Kevan-Y and removed request for JerryHue October 26, 2022 23:35
@humphd humphd requested a review from Kevan-Y October 29, 2022 15:24
Kevan-Y
Kevan-Y previously approved these changes Oct 31, 2022
View reviewed changes
src/web/app/src/components/DependenciesTable/Row.tsx Outdated Show resolved Hide resolved
@humphd
Copy link
Contributor

humphd commented Oct 31, 2022

@Eakam1007 can we get this finished today and squashed/rebased so that we can land before midnight?

@humphd humphd requested a review from Kevan-Y October 31, 2022 14:04
Kevan-Y
Kevan-Y previously approved these changes Oct 31, 2022
View reviewed changes
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Oct 31, 2022

@Eakam1007 Can you squash commit? Thank you

@Eakam1007
Update dependency font size and style
70b933c 
Update dependency row bottom border color to be lighter in dark mode

Make border style consistent across all rows

Make border style important

Co-authored-by: Kevan Yang <[email protected]>

Remove extra whitespace

Make dependency info cell border style important
@Eakam1007
Copy link
Contributor Author

Eakam1007 commented Oct 31, 2022 •
edited
Loading

@Eakam1007 Can you squash commit? Thank you

I tried squashing but I can't seem to get it work. Sorry but could I get some help here?
Edit: Had to reload a few times to see the changes

@Eakam1007 Eakam1007 requested a review from Kevan-Y October 31, 2022 17:26
@humphd
Copy link
Contributor

humphd commented Oct 31, 2022

@Kevan-Y can you give this your blessing and merge once you're happy?

@Kevan-Y Kevan-Y merged commit 9c68f95 into Seneca-CDOT:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevan-Y Kevan-Y Kevan-Y approved these changes

Assignees

@Eakam1007 Eakam1007

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CSS in dependencies page
4 participants
@Eakam1007 @humphd @Kevan-Y @manekenpix