Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulgarian translation of overview page #3700

Merged
merged 3 commits into from
Nov 6, 2022

Conversation

IvaniGabrovsky
Copy link
Contributor

@IvaniGabrovsky IvaniGabrovsky commented Oct 8, 2022

Fixes #3697

Type of Change

  • New Feature: I have created an about page in Bulgarian language.

Description

The about page is in Bulgarian language, for Bulgarian speakers to being able to get a brief understand of the Telescope project and how everything works.

Example:
- Go to '/src/web/docusaurus'
- `pnpm install`
- `pnpm run start`
- Open URL 'http://localhost:4631/docs/overview'
- Click on English drop down menu
- Click on Български

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Oct 8, 2022

@sirinoks
Copy link
Contributor

@humphd I'm sorry I don't know Bulgarian :(

I can check if it at least displays and runs correctly

@humphd
Copy link
Contributor

humphd commented Oct 11, 2022

@sirinoks we're all in the same boat, I think. Hopefully @IvaniGabrovsky can get a technically-aware Bulgarian reader to review the language itself. We can review the rest.

I do see that the src/web/docusaurus/docusaurus.config.js file is out of date and needs to be rebased.

@IvaniGabrovsky
Copy link
Contributor Author

@sirinoks we're all in the same boat, I think. Hopefully @IvaniGabrovsky can get a technically-aware Bulgarian reader to review the language itself. We can review the rest.

I do see that the src/web/docusaurus/docusaurus.config.js file is out of date and needs to be rebased.

I have rebased this branch with master.

@IvaniGabrovsky
Copy link
Contributor Author

@sirinoks we're all in the same boat, I think. Hopefully @IvaniGabrovsky can get a technically-aware Bulgarian reader to review the language itself. We can review the rest.

I do see that the src/web/docusaurus/docusaurus.config.js file is out of date and needs to be rebased.

I got someone to proof read and correct any grammer mistakes. All is good now from my end.

@humphd
Copy link
Contributor

humphd commented Oct 31, 2022

@IvaniGabrovsky can we get this rebased/squashed if you want it in before midnight?

@sirinoks any chance you can do this review today? I mean the parts that aren't related to the translation.

@sirinoks
Copy link
Contributor

@humphd On it

sirinoks
sirinoks previously approved these changes Oct 31, 2022
Copy link
Contributor

@sirinoks sirinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Works.

There seems to be a bug now in our docusaurus translations mechanic, but it's not this PR's fault, I will make an issue

@humphd
Copy link
Contributor

humphd commented Oct 31, 2022

@IvaniGabrovsky this needs to be a single commit, rebased on master. See https://telescope.cdot.systems/docs/contributing/git-workflow for tips on how to do it. Once you've fixed that, we can merge this.

@mnosov622
Copy link
Contributor

Hi !

I know Bulgarian. Let me know if I can help in reviewing this PR in terms of language.

@humphd
Copy link
Contributor

humphd commented Nov 1, 2022

@mnosov622 yes please, can you read the translation @IvaniGabrovsky has done and give feedback?

@mnosov622
Copy link
Contributor

Sure !

@mnosov622
Copy link
Contributor

Translation look very clear and understandable for me ! Great job @IvaniGabrovsky :)

@manekenpix
Copy link
Member

What's the status of this PR? It seems it was reviewed. but the history is not ready. @IvaniGabrovsky can you fix the commit history? we need your changes in a single commit on top of the current upstream/master, with no merges of master into your branch.

@IvaniGabrovsky
Copy link
Contributor Author

What's the status of this PR? It seems it was reviewed. but the history is not ready. @IvaniGabrovsky can you fix the commit history? we need your changes in a single commit on top of the current upstream/master, with no merges of master into your branch.

I know what you mean. I am not sure how to squash mutiple commits into 1 commit. Could you give me an instruction how to do that?

@humphd humphd merged commit eda63fe into Seneca-CDOT:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted type: translation Translation of existing content into a different language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate about page to Bulgarian
5 participants