Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3658: About Us button in all environments redirect to the Docusaurus site in staging #3667

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

manekenpix
Copy link
Member

@manekenpix manekenpix commented Oct 2, 2022

Issue This PR Addresses

Fixes #3658

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR fixes the uses webUrl as opposed to a hardcoded url for the About us link.

Steps to test the PR

  • Run locally
  • Assert that using different env files in config to create a local .env changes the base url used in the About us link.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Oct 2, 2022

@manekenpix manekenpix merged commit d22d2e5 into Seneca-CDOT:master Oct 3, 2022
@manekenpix manekenpix deleted the fix-about-us branch October 3, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About Us button in all environments redirect to the Docusaurus site in staging
2 participants