Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign telescope react native app #3584

Merged
merged 1 commit into from
May 30, 2022
Merged

Redesign telescope react native app #3584

merged 1 commit into from
May 30, 2022

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented May 13, 2022 •
edited
Loading

Issue This PR Addresses

Fixes #3583

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Redesign Home page, and post page.

Follow-up redesigns navbar and improves CSS in the post text.

Steps to test the PR

  • pnpm i
  • cd src/mobile
  • cp .env.development .env
  • pnpm start

Demo Video

IOS

IOS.redisgn.MP4

Android

android.Redign.mp4

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented May 13, 2022

@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from 57a5ec0 to 579fdda Compare May 13, 2022 18:09
@Kevan-Y Kevan-Y requested review from tpmai22 and humphd May 13, 2022 18:11
@Kevan-Y Kevan-Y self-assigned this May 13, 2022
@Kevan-Y Kevan-Y marked this pull request as ready for review May 13, 2022 23:47
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from 579fdda to 9138de9 Compare May 14, 2022 16:17
@Kevan-Y Kevan-Y mentioned this pull request May 15, 2022
Closed
8 tasks
@AmasiaNalbandian AmasiaNalbandian self-requested a review May 17, 2022 14:00
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from 13a17dd to 1a83aec Compare May 20, 2022 13:52
DukeManh
DukeManh requested changes May 20, 2022
View reviewed changes
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great design, excellent job implementing it.

src/mobile/src/utils/getNameInitial.js Outdated Show resolved Hide resolved
src/mobile/src/utils/getNameInitial.js Outdated Show resolved Hide resolved
src/mobile/src/utils/formatPublishedDate.js Show resolved Hide resolved
src/mobile/src/components/Post/index.jsx Show resolved Hide resolved
src/mobile/src/components/Post/Pagination.jsx Outdated Show resolved Hide resolved
src/mobile/src/components/Skeleton.jsx Show resolved Hide resolved
src/mobile/src/components/PostCard.jsx Show resolved Hide resolved
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from cb0876c to 6532d3e Compare May 21, 2022 00:49
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from 6532d3e to f8cec3d Compare May 21, 2022 01:29
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from f8cec3d to a898314 Compare May 21, 2022 02:10
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch 2 times, most recently from 874d255 to ecb265a Compare May 21, 2022 21:22
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from ecb265a to e0158e1 Compare May 28, 2022 17:41
@Kevan-Y Kevan-Y requested a review from DukeManh May 28, 2022 17:41
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from e0158e1 to 8c8158a Compare May 28, 2022 17:41
DukeManh
DukeManh previously approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@DukeManh DukeManh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM

src/mobile/src/components/HomeHeader.jsx Outdated
import { Text, View, StyleSheet } from 'react-native';
import { Image } from 'react-native-elements';

const logo = require('../assets/logo.png');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es modules import please.

@Kevan-Y
Redesign home ans post telescope react native app
20f60aa 
Reorder Navigation

Add pagination in post

Fix Eslint config

Remove About page and its components
@Kevan-Y Kevan-Y force-pushed the issues/issue-3583 branch from 8c8158a to 20f60aa Compare May 30, 2022 22:02
@Kevan-Y Kevan-Y requested a review from DukeManh May 30, 2022 22:03
@Kevan-Y Kevan-Y merged commit 9815927 into Seneca-CDOT:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DukeManh DukeManh DukeManh approved these changes

@tpmai22 tpmai22 Awaiting requested review from tpmai22

@humphd humphd Awaiting requested review from humphd

@AmasiaNalbandian AmasiaNalbandian Awaiting requested review from AmasiaNalbandian

Assignees

@Kevan-Y Kevan-Y

Labels
area: React Native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign telescope react native app
2 participants
@Kevan-Y @DukeManh