-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced octokit/request
with octokit/octokit
in dependency-discovery
#3485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing much to test, since the tests themselves run just fine, which means that the behaviour has kept the same. We would extend what the service does with what the library offers us in a future PR!
@TDDR, to test it locally:
|
@TDDR Are you gonna update the other in a follow up PR? |
I also updated the usage of There is one more usage of |
Issue This PR Addresses
Fixes #3324
Type of Change
Description
This PR adds the
octokit/octokit
package to thedependency-discovery
and removesoctokit/request
.Could also update the usage of
octokit/request
in the src/web/.../StarField and the octokit/webhook usage autodeployment/webhook.js in a follow up PR?Steps to test the PR
Not 100% sure how to test the
dependency-discovery
, but the image properly builds and localhost seems to be working as intended.