Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced octokit/request with octokit/octokit in dependency-discovery #3485

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

TDDR
Copy link
Contributor

@TDDR TDDR commented Apr 14, 2022

Issue This PR Addresses

Fixes #3324

Type of Change

  • New Feature: Change which adds functionality

Description

This PR adds the octokit/octokit package to the dependency-discovery and removes octokit/request.

Could also update the usage of octokit/request in the src/web/.../StarField and the octokit/webhook usage autodeployment/webhook.js in a follow up PR?

Steps to test the PR

Not 100% sure how to test the dependency-discovery, but the image properly builds and localhost seems to be working as intended.

@gitpod-io
Copy link

gitpod-io bot commented Apr 14, 2022

@TDDR TDDR marked this pull request as draft April 14, 2022 13:31
JerryHue
JerryHue previously approved these changes Apr 16, 2022
Copy link
Contributor

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing much to test, since the tests themselves run just fine, which means that the behaviour has kept the same. We would extend what the service does with what the library offers us in a future PR!

@Kevan-Y
Copy link
Contributor

Kevan-Y commented Apr 18, 2022

@TDDR, to test it locally:

  1. pnpm i (To update package if not updated yet)
  2. cd .\src\api\dependency-discovery\
  3. pnm dev or pnpm start
  4. Go to a route like http://localhost:10500/github/@babel/core

@Kevan-Y
Copy link
Contributor

Kevan-Y commented Apr 18, 2022

@TDDR Are you gonna update the other in a follow up PR?

@TDDR
Copy link
Contributor Author

TDDR commented Apr 19, 2022

@TDDR Are you gonna update the other in a follow up PR?

I also updated the usage of octokit/core and the two plugins to be just octokit in src/api/status/src/js/octokit.js

There is one more usage of octokit/request in the Starfield, but I don't think that needs the extra capabilities of the full octokit package

@TDDR TDDR marked this pull request as ready for review April 19, 2022 18:37
@aserputov aserputov merged commit 5595c6f into Seneca-CDOT:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use octokit/octokit instead of octokit/request
7 participants