Author autocomplete (front-end) #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DukeManh
requested changes
Apr 6, 2022
DukeManh
approved these changes
Apr 7, 2022
Kevan-Y
approved these changes
Apr 7, 2022
|
@rclee91 Some CSS issues, can be fixed in a follow-up issue. |
|
I think this PR caused the following : I opened a new issue about this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
fixes #3226
fixes #1260
Type of Change
Implement author autocomplete on the search bar
Description
Steps to test the PR
Please note
It won't work on staging since
Parseron staging is messing up with the autocomplete index and the results.However, testing on
cp config/env.staging .envon this implementation won't break search. The autocomplete suggestions simply won't show up.I did the best I could with styles, but I think getting the implementation in for this PR is more important.
If anyone more experienced with styling would like to tackle this as another issue, it would be much appreciated.