-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to include Youtube channel in Signup #3411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more complicated than it needs to be. We only need to make it clear that you can specify a YouTube channel as one of your feeds, and the rest should just work (i.e., it's a normal feed URL).
@@ -106,6 +106,7 @@ const createNewProfile = async (id, body) => { | |||
githubUsername, | |||
githubAvatarUrl, | |||
blogUrl, | |||
youtubeUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to modify the schema of a user in the DB. A YouTube channel is just another RSS feed that happens to be hosted on YouTube.
@tcvan0707, according to your comment, here are my ideas to implement this:
blogs: [
{ URL: '123', type: 'blog'},
{ URL: '456', type: 'twitch'},
]
|
@tcvan0707 why did we close this? |
I am working on changes, so I will close this one and open the new PR, or can we convert this one to the actual PR? |
@tcvan0707 this is good for review right? |
This one will be closed in the future via #3505 |
Ok, focus on the other one then |
Closed via #3505 |
Issue This PR Addresses
Fixes #2676
Type of Change
Description
This PR will allow user to include their Youtube channel when registering their account in Telescope.
NOTE: This PR is not fully completed yet. I am still not able to get the feed from Youtube channel, and the
Youtube URL
does not get theMuiInputLable-shrink
. Advices are welcome ^^Steps to test the PR
pnpm services:start
localhost:8000
user1
, password:user1pass
http://localhost:8910/project/default/editor
under thetelescope_profiles
tableChecklist