-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use single nginx container for app and docusaurus #3367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @menghif.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@menghif were you planning to apply the changes in this PR to staging
and production
, or are you going to do it in a different PR?
In a followup. |
Issue This PR Addresses
Fixes #2993
Type of Change
Description
This PR adds a Dockerfile to share a single nginx container for our web app and docusaurus.
Steps to test the PR
pnpm i
pnpm services:start
Checklist