-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wiki-feed-parser, add logic to get feeds from supabase #3363
Conversation
5bfd247
to
ab1b75f
Compare
ab1b75f
to
f6ab456
Compare
f6ab456
to
4ff49ab
Compare
@TueeNguyen you said you'd update this with details on what's blocking it, can you do that? I'd like to see this get in soon. |
I'm tweaking the test, the PR should be up soon @humphd |
4ff49ab
to
63ebe4c
Compare
63ebe4c
to
d23d4ac
Compare
5eda7a1
to
f240e18
Compare
I'm nervous about landing this until after 3.0-alpha happens, since we've never tested on Staging. |
In our meeting today, we found out that this code could be removed telescope/src/api/parser/src/parser.js Lines 12 to 28 in d56306a
It creates new Feed object and saves it to Redis , I think we still need this functionality. I can file an issue on this and open a new PR
|
f240e18
to
867759c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #3465 for similar code. I copied what you did, then fixed bugs in it.
867759c
to
550a462
Compare
550a462
to
43ad30a
Compare
43ad30a
to
db0fe53
Compare
db0fe53
to
fb64760
Compare
fb64760
to
83bae5b
Compare
- Remove wiki-feed-parser, add logic to get feeds from supabase - Update test to refect on the change - Fix Supabase configs, remove secrets from env.local - Use database staging
83bae5b
to
0483606
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my machine. Looks good!!
Issue This PR Addresses
Fixes #2861
Waiting for #3373 to be merged, then update tests
Waiting for #3361 & #3359Type of Change
Description
wiki-feed-parser.js
=> will need to update tests as wellSUPABASE_URL
&SERVICE_ROLE_KEY
toparser
indocker-compose.yml
Steps to test the PR
pnpm install
pnpm services:start parser
parser
's container log, if feeds are being processed => it's goodHow to run e2e test:
pnpm services:start
pnpm jest:e2e parser
Checklist