Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Search Front-End #3353

Merged
merged 4 commits into from
Mar 29, 2022

Conversation

AmasiaNalbandian
Copy link
Contributor

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

To be able to finish the PR for search bar front-end, I need to simplify the search. The level of complexity was not required, so I simplified this functionality to be higher up from SearchPage.tsx and share across components more uniformly.

Steps to test the PR

  1. npm install
  2. cp config/env.staging .env
  3. npm run dev
  4. Try using the searchbar - should have the same functionality as previously, meaning nothing should have changed, only the method for submitting front-end changed.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@AmasiaNalbandian AmasiaNalbandian self-assigned this Mar 29, 2022
@AmasiaNalbandian AmasiaNalbandian added the area: elasticsearch Elasticsearch Related issues and pull requests label Mar 29, 2022
@AmasiaNalbandian AmasiaNalbandian added this to the 3.0-alpha Release milestone Mar 29, 2022
@gitpod-io
Copy link

gitpod-io bot commented Mar 29, 2022

@nguyenhung15913
Copy link
Contributor

image
I would recommend to change background color when we hover the bar in dark mode. Everything else is working well

Copy link
Contributor

@HyperTHD HyperTHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's certainly unfortunate that you removed my beautiful provider that took some time for me to make and I really wished you asked me to explain how it works as I would've made some time for that.

All I ask is that you make the advanced search shine brighter than ever before. Think you owe it to me to do that at least. Rest in Peace my friend :(

GTM btw

@AmasiaNalbandian
Copy link
Contributor Author

image I would recommend to change background color when we hover the bar in dark mode. Everything else is working well

@nguyenhung15913 Thanks for feedback - I'll try to address this in the PR for UI.

@AmasiaNalbandian AmasiaNalbandian deleted the simplify-search branch March 29, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: elasticsearch Elasticsearch Related issues and pull requests area: front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants