-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Search Front-End #3353
Simplify Search Front-End #3353
Conversation
2290589
to
4e5e349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's certainly unfortunate that you removed my beautiful provider that took some time for me to make and I really wished you asked me to explain how it works as I would've made some time for that.
All I ask is that you make the advanced search shine brighter than ever before. Think you owe it to me to do that at least. Rest in Peace my friend :(
GTM btw
@nguyenhung15913 Thanks for feedback - I'll try to address this in the PR for UI. |
Type of Change
Description
To be able to finish the PR for search bar front-end, I need to simplify the search. The level of complexity was not required, so I simplified this functionality to be higher up from
SearchPage.tsx
and share across components more uniformly.Steps to test the PR
npm install
cp config/env.staging .env
npm run dev
Checklist