Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer for About Screen of React Native mobile app #3320

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Footer for About Screen of React Native mobile app #3320

merged 1 commit into from
Mar 28, 2022

Conversation

nguyenhung15913
Copy link
Contributor

Issue This PR Addresses

Fixes #3203

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • Added Footer for about screen
  • Github API was not added so the contributor card still remains static

Screenshot

image

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Mar 25, 2022

@nguyenhung15913 nguyenhung15913 changed the title About footer Footer for About Screen of React Native mobile app Mar 25, 2022
@tpmai22
Copy link
Contributor

tpmai22 commented Mar 25, 2022

So the GitHub contribution card is just a placeholder for now ?

@nguyenhung15913
Copy link
Contributor Author

So the GitHub contribution card is just a placeholder for now ?

yeah. I think we should create another issue for adding github api to the footer. since it's a different feature.

@tpmai22
Copy link
Contributor

tpmai22 commented Mar 25, 2022

@nguyenhung15913 let file it and I will aprrove this PR

@nguyenhung15913 nguyenhung15913 mentioned this pull request Mar 26, 2022
Closed
JiaHua-Zou
JiaHua-Zou reviewed Mar 28, 2022
View reviewed changes
src/mobile/src/components/Footer.jsx Outdated
<Pressable
onPress={() =>
Linking.openURL(
'https://github.com/Seneca-CDOT/telescope/blob/master/docs/environment-setup.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to this page is not found. Did you mean this link? https://github.com/Seneca-CDOT/telescope/blob/master/src/docs/docs/getting-started/environment-setup.md

src/mobile/src/components/Footer.jsx Outdated
<Pressable
onPress={() =>
Linking.openURL(
'https://github.com/Seneca-CDOT/telescope/blob/master/docs/CONTRIBUTING.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here link not found. Did you mean this one? https://github.com/Seneca-CDOT/telescope/blob/master/src/docs/docs/contributing/CONTRIBUTING.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

humphd
humphd previously approved these changes Mar 28, 2022
View reviewed changes
src/mobile/src/components/Footer.jsx
<Pressable
onPress={() =>
Linking.openURL(
'https://github.com/Seneca-CDOT/telescope/blob/master/src/docs/docs/getting-started/environment-setup.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should file a follow-up issue to use the main entry point for our docs site, since this might change.

src/mobile/src/components/Footer.jsx
<Pressable
onPress={() =>
Linking.openURL(
'https://github.com/Seneca-CDOT/telescope/blob/master/src/docs/docs/contributing/CONTRIBUTING.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here, let's point at the docs site when it's up (new issue).

JiaHua-Zou
JiaHua-Zou previously approved these changes Mar 28, 2022
View reviewed changes
Kevan-Y
Kevan-Y previously approved these changes Mar 28, 2022
View reviewed changes
tpmai22
tpmai22 previously approved these changes Mar 28, 2022
View reviewed changes
@nguyenhung15913
initial commit for footer
e9a985f 
 update on footer

added footer to mobile app

removed redundant import

fixed 404 links
@nguyenhung15913 nguyenhung15913 dismissed stale reviews from tpmai22, Kevan-Y, JiaHua-Zou, and humphd via e9a985f March 28, 2022 22:31
@nguyenhung15913 nguyenhung15913 merged commit fb3e764 into Seneca-CDOT:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TueeNguyen TueeNguyen TueeNguyen approved these changes

@JiaHua-Zou JiaHua-Zou JiaHua-Zou left review comments

@Kevan-Y Kevan-Y Kevan-Y left review comments

@tpmai22 tpmai22 tpmai22 left review comments

@humphd humphd humphd left review comments

@cindyorangis cindyorangis Awaiting requested review from cindyorangis

Assignees

@nguyenhung15913 nguyenhung15913

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding footer for mobile app's about screen
6 participants
@nguyenhung15913 @tpmai22 @humphd @Kevan-Y @TueeNguyen @JiaHua-Zou