-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Dockerfile sso #3307
Refactor Dockerfile sso #3307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the dev/dependencies stuff, we don't need.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/humphd/telescope/A9yaRg6rL2jAqyB7mrsLvsq5wZUw [Deployment for 6adaa55 failed] |
9d0893d
to
6adaa55
Compare
6adaa55
to
635a91a
Compare
635a91a
to
654e6d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Great, I'm gonna squash those commits. |
654e6d9
to
8188c01
Compare
8d20d0f
to
f9ee992
Compare
701dbdd
to
3bddc63
Compare
3bddc63
to
24765bd
Compare
24765bd
to
28dff96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work not giving up on this.
Update playwright to 1.20.2
28dff96
to
0ab4a11
Compare
@humphd, sorry to make you re-review again, this is the right change with pnpm + adding Docker best practices |
This i ready to go, just needs one more r+ |
Issue This PR Addresses
Fixes #1668
Type of Change
Description
Image is a bit bigger because we install the pnpm package
❯ docker images | grep refactor/sso refactor/sso new d31f703b6c2b 18 seconds ago 132MB refactor/sso old 02baf2192da0 2 weeks ago 135MB
Steps to test the PR
pnpm services:start
http://localhost/v1/auth/healthcheck
Checklist