-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize Parser service #3302
Merged
Merged
Dockerize Parser service #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for #3040 to merge first |
TDDR
requested changes
Mar 24, 2022
docker/production.yml
Outdated
# parser: | ||
# restart: unless-stopped | ||
parser: | ||
image: docker.cdot.systems/posts:${DOCKER_DEPLOY_TAG:-latest} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be parser
instead of posts
Kevan-Y
requested changes
Mar 24, 2022
Image size compare to before ❯ docker images | grep refactor/parser
refactor/parser old de119410c427 14 seconds ago 185MB
refactor/parser new 5efd1346e57b About a minute ago 170MB |
TueeNguyen
force-pushed
the
parser-docker
branch
from
March 24, 2022 14:26
26c8cc6
to
0025b1a
Compare
Looking for another round of review, probably after #3040 this gets merged to see how if the containers will be built correctly. |
Small but good improvement |
humphd
requested changes
Mar 24, 2022
TueeNguyen
force-pushed
the
parser-docker
branch
2 times, most recently
from
March 24, 2022 16:36
d58d903
to
078ac17
Compare
Kevan-Y
approved these changes
Mar 24, 2022
humphd
approved these changes
Mar 25, 2022
TueeNguyen
force-pushed
the
parser-docker
branch
from
March 25, 2022 02:19
078ac17
to
aeef9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #2111
Type of Change
Description
Steps to test the PR
pnpm services:start
localhost:8000
AND THAT'S ALL YOU NEED, NOpnpm start
Checklist